Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b97318dd
Commit
b97318dd
authored
May 14, 2020
by
Tristan Read
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove alert detail status dropdown
parent
4c0f6a93
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
26 deletions
+1
-26
app/assets/javascripts/alert_management/components/alert_details.vue
...javascripts/alert_management/components/alert_details.vue
+1
-22
spec/frontend/alert_management/components/alert_management_detail_spec.js
...ert_management/components/alert_management_detail_spec.js
+0
-4
No files found.
app/assets/javascripts/alert_management/components/alert_details.vue
View file @
b97318dd
<
script
>
<
script
>
import
*
as
Sentry
from
'
@sentry/browser
'
;
import
*
as
Sentry
from
'
@sentry/browser
'
;
import
{
import
{
GlAlert
,
GlIcon
,
GlLoadingIcon
,
GlSprintf
,
GlTabs
,
GlTab
,
GlButton
}
from
'
@gitlab/ui
'
;
GlAlert
,
GlIcon
,
GlLoadingIcon
,
GlNewDropdown
,
GlNewDropdownItem
,
GlSprintf
,
GlTabs
,
GlTab
,
GlButton
,
}
from
'
@gitlab/ui
'
;
import
{
s__
}
from
'
~/locale
'
;
import
{
s__
}
from
'
~/locale
'
;
import
query
from
'
../graphql/queries/details.query.graphql
'
;
import
query
from
'
../graphql/queries/details.query.graphql
'
;
import
{
fetchPolicies
}
from
'
~/lib/graphql
'
;
import
{
fetchPolicies
}
from
'
~/lib/graphql
'
;
...
@@ -38,8 +28,6 @@ export default {
...
@@ -38,8 +28,6 @@ export default {
GlAlert
,
GlAlert
,
GlIcon
,
GlIcon
,
GlLoadingIcon
,
GlLoadingIcon
,
GlNewDropdown
,
GlNewDropdownItem
,
GlSprintf
,
GlSprintf
,
GlTab
,
GlTab
,
GlTabs
,
GlTabs
,
...
@@ -148,15 +136,6 @@ export default {
...
@@ -148,15 +136,6 @@ export default {
class=
"gl-display-flex gl-justify-content-space-between gl-align-items-center"
class=
"gl-display-flex gl-justify-content-space-between gl-align-items-center"
>
>
<h2
data-testid=
"title"
>
{{ alert.title }}
</h2>
<h2
data-testid=
"title"
>
{{ alert.title }}
</h2>
<gl-new-dropdown
right
>
<gl-new-dropdown-item
v-for=
"(label, field) in $options.statuses"
:key=
"field"
data-testid=
"statusDropdownItem"
class=
"gl-vertical-align-middle"
>
{{ label }}
</gl-new-dropdown-item>
</gl-new-dropdown>
</div>
</div>
<gl-tabs
v-if=
"alert"
data-testid=
"alertDetailsTabs"
>
<gl-tabs
v-if=
"alert"
data-testid=
"alertDetailsTabs"
>
<gl-tab
data-testid=
"overviewTab"
:title=
"$options.i18n.overviewTitle"
>
<gl-tab
data-testid=
"overviewTab"
:title=
"$options.i18n.overviewTitle"
>
...
...
spec/frontend/alert_management/components/alert_management_detail_spec.js
View file @
b97318dd
...
@@ -110,10 +110,6 @@ describe('AlertDetails', () => {
...
@@ -110,10 +110,6 @@ describe('AlertDetails', () => {
});
});
});
});
it
(
'
renders a status dropdown containing three items
'
,
()
=>
{
expect
(
wrapper
.
findAll
(
'
[data-testid="statusDropdownItem"]
'
).
length
).
toBe
(
3
);
});
describe
(
'
Create issue from alert
'
,
()
=>
{
describe
(
'
Create issue from alert
'
,
()
=>
{
describe
(
'
createIssueFromAlertEnabled feature flag enabled
'
,
()
=>
{
describe
(
'
createIssueFromAlertEnabled feature flag enabled
'
,
()
=>
{
it
(
'
should display a button that links to new issue page
'
,
()
=>
{
it
(
'
should display a button that links to new issue page
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment