Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bd0bfdd1
Commit
bd0bfdd1
authored
Oct 31, 2018
by
Mark Chao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Redact sensitive information on workhorse log
parent
a033faa2
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
1 deletion
+9
-1
GITLAB_WORKHORSE_VERSION
GITLAB_WORKHORSE_VERSION
+1
-1
changelogs/unreleased/security-182-update-workhorse.yml
changelogs/unreleased/security-182-update-workhorse.yml
+5
-0
config/application.rb
config/application.rb
+3
-0
No files found.
GITLAB_WORKHORSE_VERSION
View file @
bd0bfdd1
7.1.
1
7.1.
3
changelogs/unreleased/security-182-update-workhorse.yml
0 → 100644
View file @
bd0bfdd1
---
title
:
Redact sensitive information on gitlab-workhorse log
merge_request
:
author
:
type
:
security
config/application.rb
View file @
bd0bfdd1
...
@@ -97,6 +97,9 @@ module Gitlab
...
@@ -97,6 +97,9 @@ module Gitlab
# - Webhook URLs (:hook)
# - Webhook URLs (:hook)
# - Sentry DSN (:sentry_dsn)
# - Sentry DSN (:sentry_dsn)
# - File content from Web Editor (:content)
# - File content from Web Editor (:content)
#
# NOTE: It is **IMPORTANT** to also update gitlab-workhorse's filter when adding parameters here to not
# introduce another security vulnerability: https://gitlab.com/gitlab-org/gitlab-workhorse/issues/182
config
.
filter_parameters
+=
[
/token$/
,
/password/
,
/secret/
,
/key$/
]
config
.
filter_parameters
+=
[
/token$/
,
/password/
,
/secret/
,
/key$/
]
config
.
filter_parameters
+=
%i(
config
.
filter_parameters
+=
%i(
certificate
certificate
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment