Merge branch 'issue#220040-fix-rails-savebang-email-handlers' into 'master'

Fix Rails/SaveBang Rubocop offenses for email handlers

See merge request gitlab-org/gitlab!58095

.rubocop_manual_todo.yml

@@ -176,8 +176,6 @@ Rails/SaveBang:
     - 'spec/lib/gitlab/database/custom_structure_spec.rb'
     - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'
     - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb'
-    - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
-    - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb'
     - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
     - 'spec/lib/gitlab/git_access_spec.rb'
     - 'spec/lib/gitlab/import_export/avatar_saver_spec.rb'

changelogs/unreleased/issue-220040-fix-rails-savebang-email-handlers.yml

+---
+title: Fix Rails/SaveBang Rubocop offenses for email handlers
+merge_request: 58095
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb

@@ -74,7 +74,7 @@ RSpec.describe Gitlab::Email::Handler::UnsubscribeHandler do
 
   context 'when the noteable could not be found' do
     before do
-      noteable.destroy
+      noteable.destroy!
     end
 
     it 'raises a NoteableNotFoundError' do