Commit bf9b8415 authored by Bob Van Landuyt's avatar Bob Van Landuyt

Merge branch 'rmv-worker-code' into 'master'

Remove the dead code and the associated worker

Closes #218231

See merge request gitlab-org/gitlab!32595
parents 9d09f38b aa291fd2
...@@ -779,14 +779,6 @@ ...@@ -779,14 +779,6 @@
:weight: 2 :weight: 2
:idempotent: :idempotent:
:tags: [] :tags: []
- :name: notifications:new_release
:feature_category: :release_orchestration
:has_external_dependencies:
:urgency: :low
:resource_boundary: :unknown
:weight: 2
:idempotent:
:tags: []
- :name: object_pool:object_pool_create - :name: object_pool:object_pool_create
:feature_category: :gitaly :feature_category: :gitaly
:has_external_dependencies: :has_external_dependencies:
......
# frozen_string_literal: true
# TODO: Worker can be removed in 13.2:
# https://gitlab.com/gitlab-org/gitlab/-/issues/218231
class NewReleaseWorker # rubocop:disable Scalability/IdempotentWorker
include ApplicationWorker
queue_namespace :notifications
feature_category :release_orchestration
weight 2
def perform(release_id)
release = Release.preloaded.find_by_id(release_id)
return unless release
NotificationService.new.send_new_release_notifications(release)
end
end
---
title: Remove the unused worker code and its queue
merge_request: 32595
author: Ravishankar
type: deprecated
...@@ -166,8 +166,6 @@ ...@@ -166,8 +166,6 @@
- 2 - 2
- - new_note - - new_note
- 2 - 2
- - notifications
- 2
- - object_pool - - object_pool
- 1 - 1
- - object_storage - - object_storage
......
# frozen_string_literal: true
# TODO: Worker can be removed in 13.2:
# https://gitlab.com/gitlab-org/gitlab/-/issues/218231
require 'spec_helper'
RSpec.describe NewReleaseWorker do
let(:release) { create(:release) }
it 'sends a new release notification' do
expect_next_instance_of(NotificationService) do |instance|
expect(instance).to receive(:send_new_release_notifications).with(release)
end
described_class.new.perform(release.id)
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment