Commit c06e89bb authored by Hordur Freyr Yngvason's avatar Hordur Freyr Yngvason Committed by Heinrich Lee Yu

Increase certmanager install timeout

We have been getting reports from users that the cluster
issuer is not ready prior to timing out, failing the
installation. Since this time is primarily spent on the
cluster and not in Sidekiq, we can probably afford to wait
a bit longer.

See e.g. https://gitlab.com/gitlab-org/gitlab/issues/33186
parent 18fe4a29
...@@ -65,7 +65,7 @@ module Clusters ...@@ -65,7 +65,7 @@ module Clusters
end end
def retry_command(command) def retry_command(command)
"for i in $(seq 1 30); do #{command} && s=0 && break || s=$?; sleep 1s; echo \"Retrying ($i)...\"; done; (exit $s)" "for i in $(seq 1 90); do #{command} && s=0 && break || s=$?; sleep 1s; echo \"Retrying ($i)...\"; done; (exit $s)"
end end
def post_delete_script def post_delete_script
......
---
title: Increase the timeout for GitLab-managed cert-manager installation to 90 seconds
(was 30 seconds)
merge_request: 19447
author:
type: fixed
...@@ -54,7 +54,7 @@ describe Clusters::Applications::CertManager do ...@@ -54,7 +54,7 @@ describe Clusters::Applications::CertManager do
'kubectl label --overwrite namespace gitlab-managed-apps certmanager.k8s.io/disable-validation=true' 'kubectl label --overwrite namespace gitlab-managed-apps certmanager.k8s.io/disable-validation=true'
]) ])
expect(subject.postinstall).to eq([ expect(subject.postinstall).to eq([
"for i in $(seq 1 30); do kubectl apply -f /data/helm/certmanager/config/cluster_issuer.yaml && s=0 && break || s=$?; sleep 1s; echo \"Retrying ($i)...\"; done; (exit $s)" "for i in $(seq 1 90); do kubectl apply -f /data/helm/certmanager/config/cluster_issuer.yaml && s=0 && break || s=$?; sleep 1s; echo \"Retrying ($i)...\"; done; (exit $s)"
]) ])
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment