Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c09b5852
Commit
c09b5852
authored
Jul 21, 2017
by
Fatih Acet
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
IssueNotesRefactor: Remove new keyword from Flash calls.
parent
6c3723d2
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
10 additions
and
10 deletions
+10
-10
app/assets/javascripts/notes/components/issue_comment_form.vue
...ssets/javascripts/notes/components/issue_comment_form.vue
+1
-1
app/assets/javascripts/notes/components/issue_discussion.vue
app/assets/javascripts/notes/components/issue_discussion.vue
+1
-1
app/assets/javascripts/notes/components/issue_note.vue
app/assets/javascripts/notes/components/issue_note.vue
+1
-1
app/assets/javascripts/notes/components/issue_note_awards_list.vue
...s/javascripts/notes/components/issue_note_awards_list.vue
+1
-1
app/assets/javascripts/notes/components/issue_notes.vue
app/assets/javascripts/notes/components/issue_notes.vue
+3
-3
app/assets/javascripts/notes/stores/issue_notes_store.js
app/assets/javascripts/notes/stores/issue_notes_store.js
+3
-3
No files found.
app/assets/javascripts/notes/components/issue_comment_form.vue
View file @
c09b5852
...
@@ -120,7 +120,7 @@ export default {
...
@@ -120,7 +120,7 @@ export default {
this
.
noteType
=
type
;
this
.
noteType
=
type
;
},
},
handleError
()
{
handleError
()
{
new
Flash
(
'
Something went wrong while adding your comment. Please try again.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong while adding your comment. Please try again.
'
);
},
},
editMyLastNote
()
{
editMyLastNote
()
{
if
(
this
.
note
===
''
)
{
if
(
this
.
note
===
''
)
{
...
...
app/assets/javascripts/notes/components/issue_discussion.vue
View file @
c09b5852
...
@@ -97,7 +97,7 @@ export default {
...
@@ -97,7 +97,7 @@ export default {
this
.
isReplying
=
false
;
this
.
isReplying
=
false
;
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong while adding your reply. Please try again.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong while adding your reply. Please try again.
'
);
});
});
},
},
},
},
...
...
app/assets/javascripts/notes/components/issue_note.vue
View file @
c09b5852
...
@@ -87,7 +87,7 @@ export default {
...
@@ -87,7 +87,7 @@ export default {
$
(
this
.
$refs
.
noteBody
.
$el
).
renderGFM
();
$
(
this
.
$refs
.
noteBody
.
$el
).
renderGFM
();
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong while editing your comment. Please try again.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong while editing your comment. Please try again.
'
);
});
});
},
},
formCancelHandler
(
shouldConfirm
)
{
formCancelHandler
(
shouldConfirm
)
{
...
...
app/assets/javascripts/notes/components/issue_note_awards_list.vue
View file @
c09b5852
...
@@ -154,7 +154,7 @@ export default {
...
@@ -154,7 +154,7 @@ export default {
$
(
this
.
$el
).
find
(
'
.award-control
'
).
tooltip
(
'
fixTitle
'
);
$
(
this
.
$el
).
find
(
'
.award-control
'
).
tooltip
(
'
fixTitle
'
);
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong on our end.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong on our end.
'
);
});
});
},
},
},
},
...
...
app/assets/javascripts/notes/components/issue_notes.vue
View file @
c09b5852
...
@@ -68,7 +68,7 @@ export default {
...
@@ -68,7 +68,7 @@ export default {
});
});
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong while fetching issue comments. Please try again.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong while fetching issue comments. Please try again.
'
);
});
});
},
},
initPolling
()
{
initPolling
()
{
...
@@ -82,7 +82,7 @@ export default {
...
@@ -82,7 +82,7 @@ export default {
this
.
$store
.
commit
(
'
setLastFetchedAt
'
,
res
.
lastFetchedAt
);
this
.
$store
.
commit
(
'
setLastFetchedAt
'
,
res
.
lastFetchedAt
);
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong while fetching latest comments.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong while fetching latest comments.
'
);
});
});
},
15000
);
},
15000
);
},
},
...
@@ -93,7 +93,7 @@ export default {
...
@@ -93,7 +93,7 @@ export default {
this
.
$store
.
dispatch
(
'
toggleAward
'
,
{
endpoint
,
awardName
,
noteId
})
this
.
$store
.
dispatch
(
'
toggleAward
'
,
{
endpoint
,
awardName
,
noteId
})
.
catch
(()
=>
{
.
catch
(()
=>
{
new
Flash
(
'
Something went wrong on our end.
'
);
// eslint-disable-line
Flash
(
'
Something went wrong on our end.
'
);
});
});
});
});
...
...
app/assets/javascripts/notes/stores/issue_notes_store.js
View file @
c09b5852
...
@@ -230,7 +230,7 @@ const actions = {
...
@@ -230,7 +230,7 @@ const actions = {
if
(
hasQuickActions
&&
Object
.
keys
(
errors
).
length
)
{
if
(
hasQuickActions
&&
Object
.
keys
(
errors
).
length
)
{
context
.
dispatch
(
'
poll
'
);
context
.
dispatch
(
'
poll
'
);
$
(
'
.js-gfm-input
'
).
trigger
(
'
clear-commands-cache.atwho
'
);
$
(
'
.js-gfm-input
'
).
trigger
(
'
clear-commands-cache.atwho
'
);
new
Flash
(
'
Commands applied
'
,
'
notice
'
,
$
(
noteData
.
flashContainer
));
// eslint-disable-line
Flash
(
'
Commands applied
'
,
'
notice
'
,
$
(
noteData
.
flashContainer
));
}
}
if
(
commandsChanges
&&
commandsChanges
.
emoji_award
)
{
if
(
commandsChanges
&&
commandsChanges
.
emoji_award
)
{
...
@@ -241,12 +241,12 @@ const actions = {
...
@@ -241,12 +241,12 @@ const actions = {
awardsHandler
.
scrollToAwards
();
awardsHandler
.
scrollToAwards
();
}).
catch
(()
=>
{
}).
catch
(()
=>
{
const
msg
=
'
Something went wrong while adding your award. Please try again.
'
;
const
msg
=
'
Something went wrong while adding your award. Please try again.
'
;
new
Flash
(
msg
,
$
(
noteData
.
flashContainer
));
// eslint-disable-line
Flash
(
msg
,
$
(
noteData
.
flashContainer
));
});
});
}
}
if
(
errors
&&
errors
.
commands_only
)
{
if
(
errors
&&
errors
.
commands_only
)
{
new
Flash
(
errors
.
commands_only
,
'
notice
'
,
$
(
noteData
.
flashContainer
));
// eslint-disable-line
Flash
(
errors
.
commands_only
,
'
notice
'
,
$
(
noteData
.
flashContainer
));
}
}
context
.
commit
(
'
removePlaceholderNotes
'
);
context
.
commit
(
'
removePlaceholderNotes
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment