Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c3bab430
Commit
c3bab430
authored
Dec 21, 2021
by
Aleksei Lipniagov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Fix Multistore FF for empty DB"
This reverts commit
f7bdab1b
.
parent
9d90d5a3
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
8 deletions
+4
-8
config/initializers/active_record_transaction_observer.rb
config/initializers/active_record_transaction_observer.rb
+2
-2
lib/gitlab/redis/multi_store.rb
lib/gitlab/redis/multi_store.rb
+2
-6
No files found.
config/initializers/active_record_transaction_observer.rb
View file @
c3bab430
# frozen_string_literal: true
# frozen_string_literal: true
return
unless
Gitlab
.
com?
||
Gitlab
.
dev_or_test_env?
def
feature_flags_available?
def
feature_flags_available?
# When the DBMS is not available, an exception (e.g. PG::ConnectionBad) is raised
# When the DBMS is not available, an exception (e.g. PG::ConnectionBad) is raised
active_db_connection
=
ActiveRecord
::
Base
.
connection
.
active?
rescue
false
active_db_connection
=
ActiveRecord
::
Base
.
connection
.
active?
rescue
false
...
@@ -9,8 +11,6 @@ rescue ActiveRecord::NoDatabaseError
...
@@ -9,8 +11,6 @@ rescue ActiveRecord::NoDatabaseError
false
false
end
end
return
unless
Gitlab
.
com?
||
Gitlab
.
dev_or_test_env?
Gitlab
::
Application
.
configure
do
Gitlab
::
Application
.
configure
do
if
feature_flags_available?
&&
::
Feature
.
enabled?
(
:active_record_transactions_tracking
,
type: :ops
,
default_enabled: :yaml
)
if
feature_flags_available?
&&
::
Feature
.
enabled?
(
:active_record_transactions_tracking
,
type: :ops
,
default_enabled: :yaml
)
Gitlab
::
Database
::
Transaction
::
Observer
.
register!
Gitlab
::
Database
::
Transaction
::
Observer
.
register!
...
...
lib/gitlab/redis/multi_store.rb
View file @
c3bab430
...
@@ -97,15 +97,11 @@ module Gitlab
...
@@ -97,15 +97,11 @@ module Gitlab
end
end
def
use_primary_and_secondary_stores?
def
use_primary_and_secondary_stores?
feature_flags_available?
&&
Feature
.
enabled?
(
"use_primary_and_secondary_stores_for_
#{
instance_name
.
underscore
}
"
,
default_enabled: :yaml
)
&&
!
same_redis_store?
Feature
.
enabled?
(
"use_primary_and_secondary_stores_for_
#{
instance_name
.
underscore
}
"
,
default_enabled: :yaml
)
&&
!
same_redis_store?
end
end
def
use_primary_store_as_default?
def
use_primary_store_as_default?
feature_flags_available?
&&
Feature
.
enabled?
(
"use_primary_store_as_default_for_
#{
instance_name
.
underscore
}
"
,
default_enabled: :yaml
)
&&
!
same_redis_store?
Feature
.
enabled?
(
"use_primary_store_as_default_for_
#{
instance_name
.
underscore
}
"
,
default_enabled: :yaml
)
&&
!
same_redis_store?
end
end
private
private
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment