Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c4124fce
Commit
c4124fce
authored
Oct 30, 2017
by
Oswaldo Ferreira
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move locked check to a guard-clause
parent
7e60c764
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
app/models/merge_request.rb
app/models/merge_request.rb
+3
-1
No files found.
app/models/merge_request.rb
View file @
c4124fce
...
@@ -398,7 +398,9 @@ class MergeRequest < ActiveRecord::Base
...
@@ -398,7 +398,9 @@ class MergeRequest < ActiveRecord::Base
def
merge_ongoing?
def
merge_ongoing?
# While the MergeRequest is locked, it should present itself as 'merge ongoing'.
# While the MergeRequest is locked, it should present itself as 'merge ongoing'.
# The unlocking process is handled by StuckMergeJobsWorker scheduled in Cron.
# The unlocking process is handled by StuckMergeJobsWorker scheduled in Cron.
locked?
||
!!
merge_jid
&&
!
merged?
&&
Gitlab
::
SidekiqStatus
.
running?
(
merge_jid
)
return
true
if
locked?
!!
merge_jid
&&
!
merged?
&&
Gitlab
::
SidekiqStatus
.
running?
(
merge_jid
)
end
end
def
closed_without_fork?
def
closed_without_fork?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment