Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cabc131c
Commit
cabc131c
authored
Oct 25, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Stop unauthized users dragging on issue boards
Closes #23763
parent
f289983d
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
CHANGELOG.md
CHANGELOG.md
+2
-1
app/helpers/boards_helper.rb
app/helpers/boards_helper.rb
+1
-1
spec/features/boards/boards_spec.rb
spec/features/boards/boards_spec.rb
+4
-0
No files found.
CHANGELOG.md
View file @
cabc131c
...
...
@@ -24,6 +24,7 @@ Please view this file on the master branch, on stable branches it's out of date.
-
Expire and build repository cache after project import
-
Fix 404 for group pages when GitLab setup uses relative url
-
Simpler arguments passed to named_route on toggle_award_url helper method
-
Fix unauthorized users dragging on issue boards
-
Better handle when no users were selected for adding to group or project. (Linus Thiel)
-
Only show register tab if signup enabled.
...
...
app/helpers/boards_helper.rb
View file @
cabc131c
...
...
@@ -5,7 +5,7 @@ module BoardsHelper
{
endpoint:
namespace_project_boards_path
(
@project
.
namespace
,
@project
),
board_id:
board
.
id
,
disabled:
!
can?
(
current_user
,
:admin_list
,
@project
)
,
disabled:
"
#{
!
can?
(
current_user
,
:admin_list
,
@project
)
}
"
,
issue_link_base:
namespace_project_issues_path
(
@project
.
namespace
,
@project
)
}
end
...
...
spec/features/boards/boards_spec.rb
View file @
cabc131c
...
...
@@ -624,6 +624,10 @@ describe 'Issue Boards', feature: true, js: true do
it
'does not show create new list'
do
expect
(
page
).
not_to
have_selector
(
'.js-new-board-list'
)
end
it
'does not allow dragging'
do
expect
(
page
).
not_to
have_selector
(
'.user-can-drag'
)
end
end
context
'as guest user'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment