Avoid using magic variable in spec

ce14c20a · Matija Čupić · 837ab8c5 · ce14c20a
Commit ce14c20a authored Nov 15, 2018 by Matija Čupić
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb .../lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb +3 -3

No files found.
--- a/spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb
+++ b/spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb
@@ -44,9 +44,9 @@ describe Gitlab::Ci::Pipeline::Chain::Validate::Repository do

  context 'when ref is ambiguous' do
    let(:project) do
-      p = create(:project, :repository)
-      p.repository.add_tag(user, 'master', 'master')
-      p
+      create(:project, :repository).tap do |proj|
+        proj.repository.add_tag(user, 'master', 'master')
+      end
    end
    let(:command) do
      Gitlab::Ci::Pipeline::Chain::Command.new(