Merge branch 'frozen-string-enable-apps-services-inner' into 'master'

Enable frozen string in app/services/**/*.rb

See merge request gitlab-org/gitlab-ce!20656

app/services/application_settings/base_service.rb

+# frozen_string_literal: true
+
 module ApplicationSettings
   class BaseService < ::BaseService
     def initialize(application_setting, user, params = {})

app/services/application_settings/update_service.rb

+# frozen_string_literal: true
+
 module ApplicationSettings
   class UpdateService < ApplicationSettings::BaseService
     attr_reader :params, :application_setting

app/services/applications/create_service.rb

+# frozen_string_literal: true
+
 module Applications
   class CreateService
     def initialize(current_user, params)

app/services/auth/container_registry_authentication_service.rb

+# frozen_string_literal: true
+
 module Auth
   class ContainerRegistryAuthenticationService < BaseService
     AUDIENCE = 'container_registry'.freeze

app/services/badges/base_service.rb

+# frozen_string_literal: true
+
 module Badges
   class BaseService
     protected

app/services/badges/build_service.rb

+# frozen_string_literal: true
+
 module Badges
   class BuildService < Badges::BaseService
     # returns the created badge

app/services/badges/create_service.rb

+# frozen_string_literal: true
+
 module Badges
   class CreateService < Badges::BaseService
     # returns the created badge

app/services/badges/update_service.rb

+# frozen_string_literal: true
+
 module Badges
   class UpdateService < Badges::BaseService
     # returns the updated badge

app/services/boards/base_service.rb

+# frozen_string_literal: true
+
 module Boards
   class BaseService < ::BaseService
     # Parent can either a group or a project

app/services/boards/create_service.rb

+# frozen_string_literal: true
+
 module Boards
   class CreateService < Boards::BaseService
     def execute

app/services/boards/issues/create_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Issues
     class CreateService < Boards::BaseService

app/services/boards/issues/list_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Issues
     class ListService < Boards::BaseService

app/services/boards/issues/move_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Issues
     class MoveService < Boards::BaseService

app/services/boards/list_service.rb

+# frozen_string_literal: true
+
 module Boards
   class ListService < Boards::BaseService
     def execute

app/services/boards/lists/create_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Lists
     class CreateService < Boards::BaseService

app/services/boards/lists/destroy_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Lists
     class DestroyService < Boards::BaseService

app/services/boards/lists/generate_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Lists
     class GenerateService < Boards::BaseService

app/services/boards/lists/list_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Lists
     class ListService < Boards::BaseService

app/services/boards/lists/move_service.rb

+# frozen_string_literal: true
+
 module Boards
   module Lists
     class MoveService < Boards::BaseService

app/services/chat_names/authorize_user_service.rb

+# frozen_string_literal: true
+
 module ChatNames
   class AuthorizeUserService
     include Gitlab::Routing

app/services/chat_names/find_user_service.rb

+# frozen_string_literal: true
+
 module ChatNames
   class FindUserService
     def initialize(service, params)

app/services/ci/create_pipeline_schedule_service.rb

+# frozen_string_literal: true
+
 module Ci
   class CreatePipelineScheduleService < BaseService
     def execute

app/services/ci/create_pipeline_service.rb

+# frozen_string_literal: true
+
 module Ci
   class CreatePipelineService < BaseService
     attr_reader :pipeline

app/services/ci/ensure_stage_service.rb

+# frozen_string_literal: true
+
 module Ci
   ##
   # We call this service everytime we persist a CI/CD job.

app/services/ci/extract_sections_from_build_trace_service.rb

+# frozen_string_literal: true
+
 module Ci
   class ExtractSectionsFromBuildTraceService < BaseService
     def execute(build)

app/services/ci/fetch_kubernetes_token_service.rb

+# frozen_string_literal: true
+
 ##
 # TODO:
 # Almost components in this class were copied from app/models/project_services/kubernetes_service.rb

app/services/ci/pipeline_trigger_service.rb

+# frozen_string_literal: true
+
 module Ci
   class PipelineTriggerService < BaseService
     include Gitlab::Utils::StrongMemoize

app/services/ci/play_build_service.rb

+# frozen_string_literal: true
+
 module Ci
   class PlayBuildService < ::BaseService
     def execute(build)

app/services/ci/process_pipeline_service.rb

+# frozen_string_literal: true
+
 module Ci
   class ProcessPipelineService < BaseService
     attr_reader :pipeline

app/services/ci/register_job_service.rb

+# frozen_string_literal: true
+
 module Ci
   # This class responsible for assigning
   # proper pending build to runner on runner API request

app/services/ci/retry_build_service.rb

+# frozen_string_literal: true
+
 module Ci
   class RetryBuildService < ::BaseService
     CLONE_ACCESSORS = %i[pipeline project ref tag options commands name

app/services/ci/retry_pipeline_service.rb

+# frozen_string_literal: true
+
 module Ci
   class RetryPipelineService < ::BaseService
     include Gitlab::OptimisticLocking

app/services/ci/stop_environments_service.rb

+# frozen_string_literal: true
+
 module Ci
   class StopEnvironmentsService < BaseService
     attr_reader :ref

app/services/ci/update_build_queue_service.rb

+# frozen_string_literal: true
+
 module Ci
   class UpdateBuildQueueService
     def execute(build)

app/services/ci/update_runner_service.rb

+# frozen_string_literal: true
+
 module Ci
   class UpdateRunnerService
     attr_reader :runner

app/services/clusters/applications/base_helm_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class BaseHelmService

app/services/clusters/applications/check_ingress_ip_address_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class CheckIngressIpAddressService < BaseHelmService

app/services/clusters/applications/check_installation_progress_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class CheckInstallationProgressService < BaseHelmService

app/services/clusters/applications/install_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class InstallService < BaseHelmService

app/services/clusters/applications/schedule_installation_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Applications
     class ScheduleInstallationService < ::BaseService

app/services/clusters/create_service.rb

+# frozen_string_literal: true
+
 module Clusters
   class CreateService < BaseService
     attr_reader :access_token

app/services/clusters/gcp/fetch_operation_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Gcp
     class FetchOperationService

app/services/clusters/gcp/finalize_creation_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Gcp
     class FinalizeCreationService

app/services/clusters/gcp/provision_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Gcp
     class ProvisionService

app/services/clusters/gcp/verify_provision_status_service.rb

+# frozen_string_literal: true
+
 module Clusters
   module Gcp
     class VerifyProvisionStatusService

app/services/clusters/update_service.rb

+# frozen_string_literal: true
+
 module Clusters
   class UpdateService < BaseService
     def execute(cluster)

app/services/commits/change_service.rb

+# frozen_string_literal: true
+
 module Commits
   class ChangeService < Commits::CreateService
     def initialize(*args)

app/services/commits/cherry_pick_service.rb

+# frozen_string_literal: true
+
 module Commits
   class CherryPickService < ChangeService
     def create_commit!

app/services/commits/create_service.rb

+# frozen_string_literal: true
+
 module Commits
   class CreateService < ::BaseService
     ValidationError = Class.new(StandardError)

app/services/commits/revert_service.rb

+# frozen_string_literal: true
+
 module Commits
   class RevertService < ChangeService
     def create_commit!

app/services/concerns/exclusive_lease_guard.rb

+# frozen_string_literal: true
+
 #
 # Concern that helps with getting an exclusive lease for running a block
 # of code.

app/services/concerns/issues/resolve_discussions.rb

+# frozen_string_literal: true
+
 module Issues
   module ResolveDiscussions
     include Gitlab::Utils::StrongMemoize

app/services/concerns/update_visibility_level.rb

+# frozen_string_literal: true
+
 module UpdateVisibilityLevel
   def valid_visibility_level_change?(target, new_visibility)
     # check that user is allowed to set specified visibility_level

app/services/concerns/users/new_user_notifier.rb

+# frozen_string_literal: true
+
 module Users
   module NewUserNotifier
     def notify_new_user(user, reset_token)

app/services/concerns/users/participable_service.rb

+# frozen_string_literal: true
+
 module Users
   module ParticipableService
     extend ActiveSupport::Concern

app/services/deploy_keys/create_service.rb

+# frozen_string_literal: true
+
 module DeployKeys
   class CreateService < Keys::BaseService
     def execute

app/services/deploy_tokens/create_service.rb

+# frozen_string_literal: true
+
 module DeployTokens
   class CreateService < BaseService
     def execute

app/services/discussions/base_service.rb

+# frozen_string_literal: true
+
 module Discussions
   class BaseService < ::BaseService
   end

app/services/discussions/resolve_service.rb

+# frozen_string_literal: true
+
 module Discussions
   class ResolveService < Discussions::BaseService
     def execute(one_or_more_discussions)

app/services/discussions/update_diff_position_service.rb

+# frozen_string_literal: true
+
 module Discussions
   class UpdateDiffPositionService < BaseService
     def execute(discussion)

app/services/emails/base_service.rb

+# frozen_string_literal: true
+
 module Emails
   class BaseService
     def initialize(current_user, params = {})

app/services/emails/confirm_service.rb

+# frozen_string_literal: true
+
 module Emails
   class ConfirmService < ::Emails::BaseService
     def execute(email)

app/services/emails/create_service.rb

+# frozen_string_literal: true
+
 module Emails
   class CreateService < ::Emails::BaseService
     def execute(extra_params = {})

app/services/emails/destroy_service.rb

+# frozen_string_literal: true
+
 module Emails
   class DestroyService < ::Emails::BaseService
     def execute(email)

app/services/events/render_service.rb

+# frozen_string_literal: true
+
 module Events
   class RenderService < BaseRenderer
     def execute(events, atom_request: false)

app/services/files/base_service.rb

+# frozen_string_literal: true
+
 module Files
   class BaseService < Commits::CreateService
     FileChangedError = Class.new(StandardError)

app/services/files/create_dir_service.rb

+# frozen_string_literal: true
+
 module Files
   class CreateDirService < Files::BaseService
     def create_commit!

app/services/files/create_service.rb

+# frozen_string_literal: true
+
 module Files
   class CreateService < Files::BaseService
     def create_commit!

app/services/files/delete_service.rb

+# frozen_string_literal: true
+
 module Files
   class DeleteService < Files::BaseService
     def create_commit!

app/services/files/multi_service.rb

+# frozen_string_literal: true
+
 module Files
   class MultiService < Files::BaseService
     UPDATE_FILE_ACTIONS = %w(update move delete).freeze

app/services/files/update_service.rb

+# frozen_string_literal: true
+
 module Files
   class UpdateService < Files::BaseService
     def create_commit!

app/services/gpg_keys/create_service.rb

+# frozen_string_literal: true
+
 module GpgKeys
   class CreateService < Keys::BaseService
     def execute

app/services/groups/base_service.rb

+# frozen_string_literal: true
+
 module Groups
   class BaseService < ::BaseService
     attr_accessor :group, :current_user, :params

app/services/groups/create_service.rb

+# frozen_string_literal: true
+
 module Groups
   class CreateService < Groups::BaseService
     def initialize(user, params = {})

app/services/groups/destroy_service.rb

+# frozen_string_literal: true
+
 module Groups
   class DestroyService < Groups::BaseService
     def async_execute

app/services/groups/nested_create_service.rb

+# frozen_string_literal: true
+
 module Groups
   class NestedCreateService < Groups::BaseService
     attr_reader :group_path, :visibility_level

app/services/groups/transfer_service.rb

+# frozen_string_literal: true
+
 module Groups
   class TransferService < Groups::BaseService
     ERROR_MESSAGES = {

app/services/groups/update_service.rb

+# frozen_string_literal: true
+
 module Groups
   class UpdateService < Groups::BaseService
     include UpdateVisibilityLevel

app/services/issuable/bulk_update_service.rb

+# frozen_string_literal: true
+
 module Issuable
   class BulkUpdateService < IssuableBaseService
     def execute(type)

app/services/issuable/common_system_notes_service.rb

+# frozen_string_literal: true
+
 module Issuable
   class CommonSystemNotesService < ::BaseService
     attr_reader :issuable

app/services/issuable/destroy_service.rb

+# frozen_string_literal: true
+
 module Issuable
   class DestroyService < IssuableBaseService
     def execute(issuable)

app/services/issues/base_service.rb

+# frozen_string_literal: true
+
 module Issues
   class BaseService < ::IssuableBaseService
     def hook_data(issue, action, old_associations: {})

app/services/issues/build_service.rb

+# frozen_string_literal: true
+
 module Issues
   class BuildService < Issues::BaseService
     include ResolveDiscussions
@@ -44,14 +46,14 @@ module Issues
 
       other_note_count = discussion.notes.size - 1
 
-      discussion_info = "- [ ] #{first_note_to_resolve.author.to_reference} #{action} a [discussion](#{note_url}): "
-      discussion_info << " (+#{other_note_count} #{'comment'.pluralize(other_note_count)})" if other_note_count > 0
+      discussion_info = ["- [ ] #{first_note_to_resolve.author.to_reference} #{action} a [discussion](#{note_url}): "]
+      discussion_info << "(+#{other_note_count} #{'comment'.pluralize(other_note_count)})" if other_note_count > 0
 
       note_without_block_quotes = Banzai::Filter::BlockquoteFenceFilter.new(first_note_to_resolve.note).call
       spaces = ' ' * 4
       quote = note_without_block_quotes.lines.map { |line| "#{spaces}> #{line}" }.join
 
-      [discussion_info, quote].join("\n\n")
+      [discussion_info.join(' '), quote].join("\n\n")
     end
 
     def issue_params

app/services/issues/close_service.rb

+# frozen_string_literal: true
+
 module Issues
   class CloseService < Issues::BaseService
     # Closes the supplied issue if the current user is able to do so.

app/services/issues/create_service.rb

+# frozen_string_literal: true
+
 module Issues
   class CreateService < Issues::BaseService
     include SpamCheckService

app/services/issues/duplicate_service.rb

+# frozen_string_literal: true
+
 module Issues
   class DuplicateService < Issues::BaseService
     def execute(duplicate_issue, canonical_issue)

app/services/issues/fetch_referenced_merge_requests_service.rb

+# frozen_string_literal: true
+
 module Issues
   class FetchReferencedMergeRequestsService < Issues::BaseService
     def execute(issue)

app/services/issues/move_service.rb

+# frozen_string_literal: true
+
 module Issues
   class MoveService < Issues::BaseService
     MoveError = Class.new(StandardError)

app/services/issues/reopen_service.rb

+# frozen_string_literal: true
+
 module Issues
   class ReopenService < Issues::BaseService
     def execute(issue)

app/services/issues/update_service.rb

+# frozen_string_literal: true
+
 module Issues
   class UpdateService < Issues::BaseService
     include SpamCheckService

app/services/keys/base_service.rb

+# frozen_string_literal: true
+
 module Keys
   class BaseService
     attr_accessor :user, :params

app/services/keys/create_service.rb

+# frozen_string_literal: true
+
 module Keys
   class CreateService < ::Keys::BaseService
     def execute

app/services/keys/destroy_service.rb

+# frozen_string_literal: true
+
 module Keys
   class DestroyService < ::Keys::BaseService
     def execute(key)

app/services/keys/last_used_service.rb

+# frozen_string_literal: true
+
 module Keys
   class LastUsedService
     TIMEOUT = 1.day.to_i

app/services/labels/base_service.rb

+# frozen_string_literal: true
+
 module Labels
   class BaseService < ::BaseService
     COLOR_NAME_TO_HEX = {

app/services/labels/create_service.rb

+# frozen_string_literal: true
+
 module Labels
   class CreateService < Labels::BaseService
     def initialize(params = {})

app/services/labels/find_or_create_service.rb

+# frozen_string_literal: true
+
 module Labels
   class FindOrCreateService
     def initialize(current_user, parent, params = {})

app/services/labels/promote_service.rb

+# frozen_string_literal: true
+
 module Labels
   class PromoteService < BaseService
     BATCH_SIZE = 1000

app/services/labels/transfer_service.rb

+# frozen_string_literal: true
+
 # Labels::TransferService class
 #
 # User for recreate the missing group labels at project level

app/services/labels/update_service.rb

+# frozen_string_literal: true
+
 module Labels
   class UpdateService < Labels::BaseService
     def initialize(params = {})

changelogs/unreleased/frozen-string-enable-apps-services-inner.yml

+---
+title: Enable frozen string in app/services/**/*.rb
+merge_request: 20656
+author: gfyoung
+type: performance