Merge branch '342797-follow-up-from-remove-nodejs-scan-scanning-gitlab-org-gitlab' into 'master'

ci: Remove the 'nodejs-scan-sast' job which isn't used anymore

See merge request gitlab-org/gitlab!72173

.gitlab/ci/reports.gitlab-ci.yml

@@ -34,10 +34,6 @@ brakeman-sast:
   rules: !reference [".reports:rules:brakeman-sast", rules]
   allow_failure: true
 
-nodejs-scan-sast:
-  rules: !reference [".reports:rules:nodejs-scan-sast", rules]
-  allow_failure: true
-
 semgrep-sast:
   rules: !reference [".reports:rules:semgrep-sast", rules]
   allow_failure: true

.gitlab/ci/rules.gitlab-ci.yml

@@ -1265,15 +1265,6 @@
         - '**/*.rb'
         - '**/Gemfile'
 
-.reports:rules:nodejs-scan-sast:
-  rules:
-    - if: $SAST_DISABLED
-      when: never
-    - if: $SAST_EXCLUDED_ANALYZERS =~ /nodejs-scan/
-      when: never
-    - changes:
-        - '**/package.json'
-
 .reports:rules:gosec-sast:
   rules:
     - if: $SAST_DISABLED

doc/development/pipelines.md

@@ -231,7 +231,6 @@ graph RL;
     1-16["brakeman-sast"];
     1-17["eslint-sast"];
     1-18["kubesec-sast"];
-    1-19["nodejs-scan-sast"];
     1-20["secrets-sast"];
     1-21["static-analysis (14 minutes)"];
     click 1-21 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914471&udv=0"
@@ -333,7 +332,6 @@ graph RL;
     1-16["brakeman-sast"];
     1-17["eslint-sast"];
     1-18["kubesec-sast"];
-    1-19["nodejs-scan-sast"];
     1-20["secrets-sast"];
     1-21["static-analysis (14 minutes)"];
     click 1-21 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914471&udv=0"
@@ -459,7 +457,6 @@ graph RL;
     1-16["brakeman-sast"];
     1-17["eslint-sast"];
     1-18["kubesec-sast"];
-    1-19["nodejs-scan-sast"];
     1-20["secrets-sast"];
     1-21["static-analysis (14 minutes)"];
     click 1-21 "https://app.periscopedata.com/app/gitlab/652085/Engineering-Productivity---Pipeline-Build-Durations?widget=6914471&udv=0"