Merge branch '221043-enable-similarity-search-feature-flags-by-default' into 'master'

Enable similarity search feature flags by default

Closes #221043

See merge request gitlab-org/gitlab!38675

changelogs/unreleased/221043-enable-similarity-search-feature-flags-by-default.yml

+---
+title: Order projects within the project dropdown by relevance in analytics features
+merge_request: 38675
+author:
+type: changed

ee/app/controllers/analytics/cycle_analytics_controller.rb

@@ -17,7 +17,7 @@ class Analytics::CycleAnalyticsController < Analytics::ApplicationController
     push_frontend_feature_flag(:value_stream_analytics_path_navigation, @group)
     push_frontend_feature_flag(:value_stream_analytics_filter_bar, @group)
     push_frontend_feature_flag(:value_stream_analytics_create_multiple_value_streams, @group)
-    push_frontend_feature_flag(:analytics_similarity_search, @group)
+    push_frontend_feature_flag(:analytics_similarity_search, @group, default_enabled: true)
   end
 
   private

ee/app/controllers/analytics/productivity_analytics_controller.rb

@@ -19,7 +19,7 @@ module Analytics
 
     before_action -> {
       push_frontend_feature_flag(:productivity_analytics_scatterplot_enabled, default_enabled: true)
-      push_frontend_feature_flag(:analytics_similarity_search, @group)
+      push_frontend_feature_flag(:analytics_similarity_search, @group, default_enabled: true)
     }
 
     before_action :validate_params, only: :show, if: -> { request.format.json? }

ee/app/controllers/groups/analytics/productivity_analytics_controller.rb

@@ -19,7 +19,7 @@ class Groups::Analytics::ProductivityAnalyticsController < Groups::Analytics::Ap
   }
   before_action -> {
     push_frontend_feature_flag(:productivity_analytics_scatterplot_enabled, default_enabled: true)
-    push_frontend_feature_flag(:analytics_similarity_search, @group)
+    push_frontend_feature_flag(:analytics_similarity_search, @group, default_enabled: true)
   }
 
   before_action :validate_params, only: :show, if: -> { request.format.json? }

lib/api/groups.rb

@@ -121,7 +121,7 @@ module API
 
       # rubocop: disable CodeReuse/ActiveRecord
       def handle_similarity_order(group, projects)
-        if params[:search].present? && Feature.enabled?(:similarity_search, group)
+        if params[:search].present? && Feature.enabled?(:similarity_search, group, default_enabled: true)
           projects.sorted_by_similarity_desc(params[:search])
         else
           order_options = { name: :asc }