Make serverless template a valid abstract template

lib/gitlab/ci/templates/Serverless.gitlab-ci.yml

@@ -39,10 +39,3 @@ stages:
    - tm -n "$KUBE_NAMESPACE" set registry-auth gitlab-registry --registry "$CI_REGISTRY" --username "$CI_REGISTRY_USER" --password "$CI_JOB_TOKEN" --push
    - tm -n "$KUBE_NAMESPACE" set registry-auth gitlab-registry --registry "$CI_REGISTRY" --username "$CI_DEPLOY_USER" --password "$CI_DEPLOY_PASSWORD" --pull
    - tm -n "$KUBE_NAMESPACE" deploy --wait
-
-deploy-functions:
-  extends: .serverless:deploy:functions
-  environment: production
-  only:
-    variables:
-      - $CI_COMMIT_MESSAGE =~ /\[serverless deploy-functions\]/

spec/lib/gitlab/ci/templates/templates_spec.rb

@@ -3,9 +3,40 @@
 require 'spec_helper'
 
 describe "CI YML Templates" do
-  Gitlab::Template::GitlabCiYmlTemplate.all.each do |template|
-    it "#{template.name} should be valid" do
-      expect { Gitlab::Ci::YamlProcessor.new(template.content) }.not_to raise_error
+  ABSTRACT_TEMPLATES = %w[Serverless]
+
+  def self.concrete_templates
+    Gitlab::Template::GitlabCiYmlTemplate.all.reject do |template|
+      ABSTRACT_TEMPLATES.include?(template.name)
+    end
+  end
+
+  def self.abstract_templates
+    Gitlab::Template::GitlabCiYmlTemplate.all.select do |template|
+      ABSTRACT_TEMPLATES.include?(template.name)
+    end
+  end
+
+  describe 'concrete templates with CI/CD jobs' do
+    concrete_templates.each do |template|
+      it "#{template.name} template should be valid" do
+        expect { Gitlab::Ci::YamlProcessor.new(template.content) }
+          .not_to raise_error
+      end
+    end
+  end
+
+  describe 'abstract templates without concrete jobs defined' do
+    abstract_templates.each do |template|
+      it "#{template.name} template should be valid after being implemented" do
+        content = template.content + <<~EOS
+          concrete_build_implemented_by_a_user:
+            stage: build
+            script: do something
+        EOS
+
+        expect { Gitlab::Ci::YamlProcessor.new(content) }.not_to raise_error
+      end
     end
   end
 end