Merge branch 'tr-fix-error-tracking-hmr' into 'master'

Fix hot module reload for error tracking pages

See merge request gitlab-org/gitlab!25068

app/assets/javascripts/error_tracking/details.js

@@ -8,28 +8,30 @@ import csrf from '~/lib/utils/csrf';
 Vue.use(VueApollo);
 
 export default () => {
+  const selector = '#js-error_details';
+
+  const domEl = document.querySelector(selector);
+  const {
+    issueId,
+    projectPath,
+    issueUpdatePath,
+    issueStackTracePath,
+    projectIssuesPath,
+  } = domEl.dataset;
+
   const apolloProvider = new VueApollo({
     defaultClient: createDefaultClient(),
   });
 
   // eslint-disable-next-line no-new
   new Vue({
-    el: '#js-error_details',
+    el: selector,
     apolloProvider,
     components: {
       ErrorDetails,
     },
     store,
     render(createElement) {
-      const domEl = document.querySelector(this.$options.el);
-      const {
-        issueId,
-        projectPath,
-        issueUpdatePath,
-        issueStackTracePath,
-        projectIssuesPath,
-      } = domEl.dataset;
-
       return createElement('error-details', {
         props: {
           issueId,

app/assets/javascripts/error_tracking/list.js

@@ -4,15 +4,9 @@ import store from './store';
 import ErrorTrackingList from './components/error_tracking_list.vue';
 
 export default () => {
-  // eslint-disable-next-line no-new
-  new Vue({
-    el: '#js-error_tracking',
-    components: {
-      ErrorTrackingList,
-    },
-    store,
-    render(createElement) {
-      const domEl = document.querySelector(this.$options.el);
+  const selector = '#js-error_tracking';
+
+  const domEl = document.querySelector(selector);
   const {
     indexPath,
     enableErrorTrackingLink,
@@ -25,6 +19,14 @@ export default () => {
   errorTrackingEnabled = parseBoolean(errorTrackingEnabled);
   userCanEnableErrorTracking = parseBoolean(userCanEnableErrorTracking);
 
+  // eslint-disable-next-line no-new
+  new Vue({
+    el: selector,
+    components: {
+      ErrorTrackingList,
+    },
+    store,
+    render(createElement) {
       return createElement('error-tracking-list', {
         props: {
           indexPath,