Update specs to use doubles

- Rename execute! to execute
- Add update_alert_management_alerts policy

app/graphql/mutations/alert_management/base.rb

@@ -18,6 +18,8 @@ module Mutations
             null: true,
             description: "The alert after mutation"
 
+      authorize :update_alert_management_alerts
+
       private
 
       def find_object(project_path:, iid:)

app/graphql/mutations/alert_management/update_alert_status.rb

@@ -9,8 +9,6 @@ module Mutations
                required: true,
                description: 'The status to set the alert'
 
-      authorize :read_alert_management_alerts
-
       def resolve(args)
         alert = authorized_find!(project_path: args[:project_path], iid: args[:iid])
 
@@ -22,7 +20,7 @@ module Mutations
 
       def update_status(alert, status)
         service = ::AlertManagement::UpdateAlertStatusService.new(alert, status)
-        service.execute!
+        service.execute
       end
 
       def prepare_response(result)

app/policies/project_policy.rb

@@ -240,6 +240,7 @@ class ProjectPolicy < BasePolicy
     enable :read_prometheus
     enable :read_metrics_dashboard_annotation
     enable :read_alert_management_alerts
+    enable :update_alert_management_alerts
     enable :metrics_dashboard
   end
 

app/services/alert_management/update_alert_status_service.rb

@@ -7,7 +7,7 @@ module AlertManagement
       @status = status
     end
 
-    def execute!
+    def execute
       return error_response('Invalid status') unless AlertManagement::Alert.statuses.key?(status.to_s)
 
       alert.status = status

spec/graphql/mutations/alert_management/update_alert_status_spec.rb

@@ -29,28 +29,34 @@ describe Mutations::AlertManagement::UpdateAlertStatus do
       end
 
       context 'error occurs when updating' do
-        before do
-          # Stubbing and error on alert
+        it 'returns the alert with errors' do
+          # Stub an error on the alert
           allow_next_instance_of(Resolvers::AlertManagementAlertResolver) do |resolver|
             allow(resolver).to receive(:resolve).and_return(alert)
           end
 
           expect(alert).to receive(:save).and_return(false)
-
-          errors = ActiveModel::Errors.new(alert)
-          errors.add(:status, :invalid)
-
-          expect(alert).to receive(:errors).and_return(errors)
+          expect(alert).to receive(:errors).and_return(
+            double(full_messages: %w(foo bar))
+          )
+          expect(resolve).to eq(
+            alert: alert,
+            errors: ['foo and bar']
+          )
         end
 
-        it 'returns the alert with no errors' do
+        context 'invalid status given' do
+          let(:new_status) { 'invalid_status' }
+
+          it 'returns the alert with errors' do
             expect(resolve).to eq(
               alert: alert,
-            errors: ['Status is invalid']
+              errors: ['Invalid status']
             )
           end
         end
       end
+    end
 
     it 'raises an error if the resource is not accessible to the user' do
       expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)

spec/services/alert_management/update_alert_status_service_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe AlertManagement::UpdateAlertStatusService do
   let_it_be(:alert) { create(:alert_management_alert, status: 'triggered') }
 
-  describe '#execute!' do
-    subject(:execute) { described_class.new(alert, new_status).execute! }
+  describe '#execute' do
+    subject(:execute) { described_class.new(alert, new_status).execute }
 
     let(:new_status) { 'acknowledged' }