Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
dc038a71
Commit
dc038a71
authored
Jul 12, 2013
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename Group#people to Group#members
parent
3232f547
Changes
10
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
14 additions
and
14 deletions
+14
-14
app/assets/javascripts/dispatcher.js.coffee
app/assets/javascripts/dispatcher.js.coffee
+1
-1
app/controllers/groups_controller.rb
app/controllers/groups_controller.rb
+1
-1
app/controllers/users_groups_controller.rb
app/controllers/users_groups_controller.rb
+2
-2
app/views/groups/_new_group_member.html.haml
app/views/groups/_new_group_member.html.haml
+1
-2
app/views/groups/members.html.haml
app/views/groups/members.html.haml
+2
-1
app/views/layouts/nav/_group.html.haml
app/views/layouts/nav/_group.html.haml
+2
-2
app/views/projects/team_members/_group_members.html.haml
app/views/projects/team_members/_group_members.html.haml
+1
-1
config/routes.rb
config/routes.rb
+1
-1
features/group/group.feature
features/group/group.feature
+1
-1
features/steps/shared/paths.rb
features/steps/shared/paths.rb
+2
-2
No files found.
app/assets/javascripts/dispatcher.js.coffee
View file @
dc038a71
...
@@ -30,7 +30,7 @@ class Dispatcher
...
@@ -30,7 +30,7 @@ class Dispatcher
new
Wall
(
project_id
)
new
Wall
(
project_id
)
when
'projects:teams:members:index'
when
'projects:teams:members:index'
new
TeamMembers
()
new
TeamMembers
()
when
'groups:
people
'
when
'groups:
members
'
new
GroupMembers
()
new
GroupMembers
()
when
'projects:tree:show'
when
'projects:tree:show'
new
TreeView
()
new
TreeView
()
...
...
app/controllers/groups_controller.rb
View file @
dc038a71
...
@@ -61,7 +61,7 @@ class GroupsController < ApplicationController
...
@@ -61,7 +61,7 @@ class GroupsController < ApplicationController
end
end
end
end
def
people
def
members
@project
=
group
.
projects
.
find
(
params
[
:project_id
])
if
params
[
:project_id
]
@project
=
group
.
projects
.
find
(
params
[
:project_id
])
if
params
[
:project_id
]
@members
=
group
.
users_groups
.
order
(
'group_access DESC'
)
@members
=
group
.
users_groups
.
order
(
'group_access DESC'
)
@users_group
=
UsersGroup
.
new
@users_group
=
UsersGroup
.
new
...
...
app/controllers/users_groups_controller.rb
View file @
dc038a71
...
@@ -9,7 +9,7 @@ class UsersGroupsController < ApplicationController
...
@@ -9,7 +9,7 @@ class UsersGroupsController < ApplicationController
def
create
def
create
@group
.
add_users
(
params
[
:user_ids
].
split
(
','
),
params
[
:group_access
])
@group
.
add_users
(
params
[
:user_ids
].
split
(
','
),
params
[
:group_access
])
redirect_to
people
_group_path
(
@group
),
notice:
'Users were successfully added.'
redirect_to
members
_group_path
(
@group
),
notice:
'Users were successfully added.'
end
end
def
update
def
update
...
@@ -21,7 +21,7 @@ class UsersGroupsController < ApplicationController
...
@@ -21,7 +21,7 @@ class UsersGroupsController < ApplicationController
@users_group
.
destroy
unless
@users_group
.
user
==
@group
.
owner
@users_group
.
destroy
unless
@users_group
.
user
==
@group
.
owner
respond_to
do
|
format
|
respond_to
do
|
format
|
format
.
html
{
redirect_to
people
_group_path
(
@group
),
notice:
'User was successfully removed from group.'
}
format
.
html
{
redirect_to
members
_group_path
(
@group
),
notice:
'User was successfully removed from group.'
}
format
.
js
{
render
nothing:
true
}
format
.
js
{
render
nothing:
true
}
end
end
end
end
...
...
app/views/groups/_new_group_member.html.haml
View file @
dc038a71
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
%fieldset
%fieldset
%legend
=
"New Group member(s) for
#{
@group
.
name
}
"
%legend
=
"New Group member(s) for
#{
@group
.
name
}
"
%h6
1. Choose
people
you want in the group
%h6
1. Choose
users
you want in the group
.clearfix
.clearfix
=
f
.
label
:user_ids
,
"People"
=
f
.
label
:user_ids
,
"People"
.input
=
users_select_tag
(
:user_ids
,
multiple:
true
,
class:
'input-large'
)
.input
=
users_select_tag
(
:user_ids
,
multiple:
true
,
class:
'input-large'
)
...
@@ -13,6 +13,5 @@
...
@@ -13,6 +13,5 @@
.input
=
select_tag
:group_access
,
options_for_select
(
UsersGroup
.
group_access_roles
,
@users_group
.
group_access
),
class:
"project-access-select chosen"
.input
=
select_tag
:group_access
,
options_for_select
(
UsersGroup
.
group_access_roles
,
@users_group
.
group_access
),
class:
"project-access-select chosen"
.form-actions
.form-actions
=
hidden_field_tag
:redirect_to
,
people_group_path
(
@group
)
=
f
.
submit
'Add users into group'
,
class:
"btn btn-create"
=
f
.
submit
'Add users into group'
,
class:
"btn btn-create"
app/views/groups/
people
.html.haml
→
app/views/groups/
members
.html.haml
View file @
dc038a71
...
@@ -10,7 +10,8 @@
...
@@ -10,7 +10,8 @@
.span6
.span6
.ui-box
.ui-box
%h5
.title
%h5
.title
#{
@group
.
name
}
Group Members
%strong
#{
@group
.
name
}
Group Members
%small
%small
(
#{
@members
.
count
}
)
(
#{
@members
.
count
}
)
%ul
.well-list
%ul
.well-list
...
...
app/views/layouts/nav/_group.html.haml
View file @
dc038a71
...
@@ -10,8 +10,8 @@
...
@@ -10,8 +10,8 @@
=
link_to
merge_requests_group_path
(
@group
)
do
=
link_to
merge_requests_group_path
(
@group
)
do
Merge Requests
Merge Requests
%span
.count
=
current_user
.
cared_merge_requests
.
opened
.
of_group
(
@group
).
count
%span
.count
=
current_user
.
cared_merge_requests
.
opened
.
of_group
(
@group
).
count
=
nav_link
(
path:
'groups#
people
'
)
do
=
nav_link
(
path:
'groups#
members
'
)
do
=
link_to
"
People"
,
people
_group_path
(
@group
)
=
link_to
"
Members"
,
members
_group_path
(
@group
)
-
if
can?
(
current_user
,
:manage_group
,
@group
)
-
if
can?
(
current_user
,
:manage_group
,
@group
)
=
nav_link
(
path:
'groups#edit'
)
do
=
nav_link
(
path:
'groups#edit'
)
do
...
...
app/views/projects/team_members/_group_members.html.haml
View file @
dc038a71
...
@@ -3,7 +3,7 @@
...
@@ -3,7 +3,7 @@
%strong
#{
@group
.
name
}
Group
%strong
#{
@group
.
name
}
Group
members (
#{
@group
.
users_groups
.
count
}
)
members (
#{
@group
.
users_groups
.
count
}
)
.pull-right
.pull-right
=
link_to
people
_group_path
(
@group
),
class:
'btn btn-small'
do
=
link_to
members
_group_path
(
@group
),
class:
'btn btn-small'
do
%i
.icon-edit
%i
.icon-edit
%ul
.well-list
%ul
.well-list
-
@group
.
users_groups
.
order
(
'group_access DESC'
).
each
do
|
member
|
-
@group
.
users_groups
.
order
(
'group_access DESC'
).
each
do
|
member
|
...
...
config/routes.rb
View file @
dc038a71
...
@@ -146,7 +146,7 @@ Gitlab::Application.routes.draw do
...
@@ -146,7 +146,7 @@ Gitlab::Application.routes.draw do
member
do
member
do
get
:issues
get
:issues
get
:merge_requests
get
:merge_requests
get
:
people
get
:
members
end
end
resources
:users_groups
,
only:
[
:create
,
:update
,
:destroy
]
resources
:users_groups
,
only:
[
:create
,
:update
,
:destroy
]
...
...
features/group/group.feature
View file @
dc038a71
...
@@ -22,7 +22,7 @@ Feature: Groups
...
@@ -22,7 +22,7 @@ Feature: Groups
@javascript
@javascript
Scenario
:
I
should add user to projects in Group
Scenario
:
I
should add user to projects in Group
Given
I have new user
"John"
Given
I have new user
"John"
When
I visit group
people
page
When
I visit group
members
page
And
I select user
"John"
from list with role
"Reporter"
And
I select user
"John"
from list with role
"Reporter"
Then
I should see user
"John"
in team list
Then
I should see user
"John"
in team list
...
...
features/steps/shared/paths.rb
View file @
dc038a71
...
@@ -21,8 +21,8 @@ module SharedPaths
...
@@ -21,8 +21,8 @@ module SharedPaths
visit
merge_requests_group_path
(
current_group
)
visit
merge_requests_group_path
(
current_group
)
end
end
step
'I visit group
people
page'
do
step
'I visit group
members
page'
do
visit
people
_group_path
(
current_group
)
visit
members
_group_path
(
current_group
)
end
end
step
'I visit group settings page'
do
step
'I visit group settings page'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment