Merge branch 'rspec-empty-line-after-letitbe-ee-spec-gitlab-elastic' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/lib/gitlab/elastic

See merge request gitlab-org/gitlab!58381

.rubocop_manual_todo.yml

@@ -473,9 +473,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb
     - ee/spec/lib/gitlab/checks/diff_check_spec.rb
     - ee/spec/lib/gitlab/code_owners/loader_spec.rb
-    - ee/spec/lib/gitlab/elastic/document_reference_spec.rb
-    - ee/spec/lib/gitlab/elastic/group_search_results_spec.rb
-    - ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
     - ee/spec/lib/gitlab/git_access_spec.rb
     - ee/spec/lib/gitlab/git_access_wiki_spec.rb
     - ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-lib-gitlab-elastic.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/lib/gitlab/elastic
+merge_request: 58381
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/lib/gitlab/elastic/document_reference_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::Elastic::DocumentReference do
   let_it_be(:issue) { create(:issue) }
+
   let(:project) { issue.project }
 
   let(:issue_as_array) { [Issue, issue.id, issue.es_id, issue.es_parent] }

ee/spec/lib/gitlab/elastic/group_search_results_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::Elastic::GroupSearchResults, :elastic do
   let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group) }
   let_it_be(:guest) { create(:user).tap { |u| group.add_user(u, Gitlab::Access::GUEST) } }
+
   let(:filters) { {} }
   let(:query) { '*' }
 

ee/spec/lib/gitlab/elastic/project_search_results_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::Elastic::ProjectSearchResults, :elastic do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project, :public, :repository) }
+
   let(:query) { 'hello world' }
   let(:repository_ref) { nil }
   let(:filters) { {} }
@@ -58,6 +59,7 @@ RSpec.describe Gitlab::Elastic::ProjectSearchResults, :elastic do
 
     context 'visibility checks' do
       let_it_be(:project) { create(:project, :public, :wiki_repo) }
+
       let(:query) { 'term' }
 
       before do