Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
df3d8a2e
Commit
df3d8a2e
authored
Jan 08, 2020
by
Nick Kipling
Committed by
Mike Greiling
Jan 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Added smart-virtual-list to test reports
Added smart-virtural-list component Updated styles for adjusted height
parent
241b89b7
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
110 additions
and
83 deletions
+110
-83
app/assets/javascripts/pipelines/components/test_reports/test_suite_table.vue
...ts/pipelines/components/test_reports/test_suite_table.vue
+47
-37
app/assets/javascripts/pipelines/components/test_reports/test_summary_table.vue
.../pipelines/components/test_reports/test_summary_table.vue
+58
-46
changelogs/unreleased/37725-test-reports-smart-list.yml
changelogs/unreleased/37725-test-reports-smart-list.yml
+5
-0
No files found.
app/assets/javascripts/pipelines/components/test_reports/test_suite_table.vue
View file @
df3d8a2e
...
...
@@ -3,11 +3,13 @@ import { mapGetters } from 'vuex';
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
store
from
'
~/pipelines/stores/test_reports
'
;
import
{
__
}
from
'
~/locale
'
;
import
SmartVirtualList
from
'
~/vue_shared/components/smart_virtual_list.vue
'
;
export
default
{
name
:
'
TestsSuiteTable
'
,
components
:
{
Icon
,
SmartVirtualList
,
},
store
,
props
:
{
...
...
@@ -23,6 +25,8 @@ export default {
return
this
.
getSuiteTests
.
length
>
0
;
},
},
maxShownRows
:
30
,
typicalRowHeight
:
75
,
};
</
script
>
...
...
@@ -34,7 +38,7 @@ export default {
</div>
</div>
<div
v-if=
"hasSuites"
class=
"test-reports-table js-test-cases-table"
>
<div
v-if=
"hasSuites"
class=
"test-reports-table
append-bottom-default
js-test-cases-table"
>
<div
role=
"row"
class=
"gl-responsive-table-row table-row-header font-weight-bold fgray"
>
<div
role=
"rowheader"
class=
"table-section section-20"
>
{{
__
(
'
Class
'
)
}}
...
...
@@ -53,14 +57,19 @@ export default {
</div>
</div>
<smart-virtual-list
:length=
"getSuiteTests.length"
:remain=
"$options.maxShownRows"
:size=
"$options.typicalRowHeight"
>
<div
v-for=
"(testCase, index) in getSuiteTests"
:key=
"index"
class=
"gl-responsive-table-row rounded align-items-md-start mt-sm
-3 js-case-row"
class=
"gl-responsive-table-row rounded align-items-md-start mt-xs
-3 js-case-row"
>
<div
class=
"table-section section-20 section-wrap"
>
<div
role=
"rowheader"
class=
"table-mobile-header"
>
{{
__
(
'
Class
'
)
}}
</div>
<div
class=
"table-mobile-content pr-md-1
"
>
{{
testCase
.
classname
}}
</div>
<div
class=
"table-mobile-content pr-md-1 text-truncate
"
>
{{
testCase
.
classname
}}
</div>
</div>
<div
class=
"table-section section-20 section-wrap"
>
...
...
@@ -94,11 +103,12 @@ export default {
<div
role=
"rowheader"
class=
"table-mobile-header"
>
{{
__
(
'
Duration
'
)
}}
</div>
<div
class=
"table-mobile-content text-right
"
>
<div
class=
"table-mobile-content text-right pr-sm-1
"
>
{{
testCase
.
formattedTime
}}
</div>
</div>
</div>
</smart-virtual-list>
</div>
<div
v-else
>
...
...
app/assets/javascripts/pipelines/components/test_reports/test_summary_table.vue
View file @
df3d8a2e
...
...
@@ -2,9 +2,13 @@
import
{
mapGetters
}
from
'
vuex
'
;
import
{
s__
}
from
'
~/locale
'
;
import
store
from
'
~/pipelines/stores/test_reports
'
;
import
SmartVirtualList
from
'
~/vue_shared/components/smart_virtual_list.vue
'
;
export
default
{
name
:
'
TestsSummaryTable
'
,
components
:
{
SmartVirtualList
,
},
store
,
props
:
{
heading
:
{
...
...
@@ -24,6 +28,8 @@ export default {
this
.
$emit
(
'
row-click
'
,
suite
);
},
},
maxShownRows
:
20
,
typicalRowHeight
:
55
,
};
</
script
>
...
...
@@ -35,7 +41,7 @@ export default {
</div>
</div>
<div
v-if=
"hasSuites"
class=
"test-reports-table js-test-suites-table"
>
<div
v-if=
"hasSuites"
class=
"test-reports-table
append-bottom-default
js-test-suites-table"
>
<div
role=
"row"
class=
"gl-responsive-table-row table-row-header font-weight-bold"
>
<div
role=
"rowheader"
class=
"table-section section-25 pl-3"
>
{{
__
(
'
Suite
'
)
}}
...
...
@@ -60,6 +66,11 @@ export default {
</div>
</div>
<smart-virtual-list
:length=
"getTestSuites.length"
:remain=
"$options.maxShownRows"
:size=
"$options.typicalRowHeight"
>
<div
v-for=
"(testSuite, index) in getTestSuites"
:key=
"index"
...
...
@@ -120,6 +131,7 @@ export default {
<div
class=
"table-mobile-content"
>
{{
testSuite
.
total_count
}}
</div>
</div>
</div>
</smart-virtual-list>
</div>
<div
v-else
>
...
...
changelogs/unreleased/37725-test-reports-smart-list.yml
0 → 100644
View file @
df3d8a2e
---
title
:
Added smart virtual list component to test reports to enhance rendering performance
merge_request
:
22381
author
:
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment