Merge branch 'remove-unused-tab-helpers' into 'master'

Remove Unused Helpers from `tab_helpers.rb`

See merge request gitlab-org/gitlab!19832

app/helpers/tab_helper.rb

@@ -108,16 +108,6 @@ module TabHelper
     current_controller?(c) && current_action?(a)
   end
 
-  def project_tab_class
-    if controller.controller_path.start_with?('projects')
-      return 'active'
-    end
-
-    if %w(services hooks deploy_keys protected_branches).include? controller.controller_name
-      "active"
-    end
-  end
-
   def branches_tab_class
     if current_controller?(:protected_branches) ||
         current_controller?(:branches) ||
@@ -125,14 +115,6 @@ module TabHelper
       'active'
     end
   end
-
-  def profile_tab_class
-    if controller.controller_path.start_with?('profiles')
-      return 'active'
-    end
-
-    'active' if current_controller?('oauth/applications')
-  end
 end
 
 TabHelper.prepend_if_ee('EE::TabHelper')

ee/app/helpers/ee/tab_helper.rb

@@ -4,15 +4,6 @@ module EE
   module TabHelper
     extend ::Gitlab::Utils::Override
 
-    override :project_tab_class
-    def project_tab_class
-      if controller.controller_name == 'push_rules'
-        'active'
-      else
-        super
-      end
-    end
-
     def analytics_controllers
       ['analytics/productivity_analytics', 'analytics/cycle_analytics']
     end

ee/spec/helpers/ee/tab_helper_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe TabHelper do
-  describe '#project_tab_class' do
-    it 'returns "active" for the push rules controller' do
-      controller = instance_double(
-        'controller',
-        controller_name: 'push_rules',
-        controller_path: '/push_rules/foo'
-      )
-
-      allow(helper)
-        .to receive(:controller)
-        .and_return(controller)
-
-      expect(helper.project_tab_class).to eq('active')
-    end
-  end
-end