Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e118e3cd
Commit
e118e3cd
authored
Oct 10, 2017
by
Jose Ivan Vargas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fixed shared discussion_comments example
parent
85b915c3
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
23 additions
and
9 deletions
+23
-9
spec/support/features/discussion_comments_shared_example.rb
spec/support/features/discussion_comments_shared_example.rb
+23
-9
No files found.
spec/support/features/discussion_comments_shared_example.rb
View file @
e118e3cd
...
@@ -4,6 +4,7 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -4,6 +4,7 @@ shared_examples 'discussion comments' do |resource_name|
let
(
:toggle_selector
)
{
"
#{
dropdown_selector
}
.dropdown-toggle"
}
let
(
:toggle_selector
)
{
"
#{
dropdown_selector
}
.dropdown-toggle"
}
let
(
:menu_selector
)
{
"
#{
dropdown_selector
}
.dropdown-menu"
}
let
(
:menu_selector
)
{
"
#{
dropdown_selector
}
.dropdown-menu"
}
let
(
:submit_selector
)
{
"
#{
form_selector
}
.js-comment-submit-button"
}
let
(
:submit_selector
)
{
"
#{
form_selector
}
.js-comment-submit-button"
}
let
(
:submit_button
)
{
".js-comment-submit-button"
}
let
(
:close_selector
)
{
"
#{
form_selector
}
.btn-comment-and-close"
}
let
(
:close_selector
)
{
"
#{
form_selector
}
.btn-comment-and-close"
}
let
(
:comments_selector
)
{
'.timeline > .note.timeline-entry'
}
let
(
:comments_selector
)
{
'.timeline > .note.timeline-entry'
}
...
@@ -85,17 +86,26 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -85,17 +86,26 @@ shared_examples 'discussion comments' do |resource_name|
find
(
toggle_selector
).
click
find
(
toggle_selector
).
click
find
(
"
#{
menu_selector
}
.divider"
).
click
find
(
"
#{
menu_selector
}
.divider"
).
click
else
else
find
(
menu_selector
).
click
within
dropdown_selector
do
find
(
'.dropdown-toggle'
).
click
expect
(
page
).
to
have_selector
menu_selector
expect
(
find
(
'.dropdown-menu'
)).
not_to
be_nil
expect
(
find
(
dropdown_selector
)).
to
have_content
'Comment'
find
(
'li[data-submit-text="Comment"]'
).
click
expect
(
find
(
submit_button
).
value
).
to
eq
"Comment"
find
(
"
#{
menu_selector
}
.divider"
).
click
find
(
'.dropdown-toggle'
).
click
page
.
driver
.
execute_script
(
"document.querySelector('.comment-type-dropdown .dropdown-menu .divider').click()"
)
expect
(
page
).
to
have_selector
menu_selector
expect
(
find
(
'.dropdown-menu'
)).
not_to
be_nil
find
(
'li[data-submit-text="Comment"]'
).
click
end
end
end
expect
(
find
(
dropdown_selector
)).
to
have_content
'Comment'
within
dropdown_selector
do
expect
(
find
(
submit_button
).
value
).
to
eq
"Comment"
end
end
end
describe
'when selecting "Start discussion"'
do
describe
'when selecting "Start discussion"'
do
...
@@ -105,7 +115,9 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -105,7 +115,9 @@ shared_examples 'discussion comments' do |resource_name|
end
end
it
'updates the submit button text and closes the dropdown'
do
it
'updates the submit button text and closes the dropdown'
do
expect
(
find
(
dropdown_selector
)).
to
have_content
'Start discussion'
within
dropdown_selector
do
expect
(
find
(
submit_button
).
value
).
to
eq
"Start discussion"
end
expect
(
page
).
not_to
have_selector
menu_selector
expect
(
page
).
not_to
have_selector
menu_selector
end
end
...
@@ -170,7 +182,9 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -170,7 +182,9 @@ shared_examples 'discussion comments' do |resource_name|
end
end
it
'updates the submit button text and closes the dropdown'
do
it
'updates the submit button text and closes the dropdown'
do
expect
(
find
(
dropdown_selector
)).
to
have_content
'Comment'
within
dropdown_selector
do
expect
(
find
(
submit_button
).
value
).
to
eq
"Comment"
end
expect
(
page
).
not_to
have_selector
menu_selector
expect
(
page
).
not_to
have_selector
menu_selector
end
end
...
@@ -218,7 +232,7 @@ shared_examples 'discussion comments' do |resource_name|
...
@@ -218,7 +232,7 @@ shared_examples 'discussion comments' do |resource_name|
end
end
it
"should show a 'Start discussion & reopen
#{
resource_name
}
' button when 'Start discussion' is selected"
do
it
"should show a 'Start discussion & reopen
#{
resource_name
}
' button when 'Start discussion' is selected"
do
find
(
toggle_selector
).
click
find
(
toggle_selector
).
send_keys
(
:return
)
find
(
"
#{
menu_selector
}
li"
,
match: :first
)
find
(
"
#{
menu_selector
}
li"
,
match: :first
)
all
(
"
#{
menu_selector
}
li"
).
last
.
click
all
(
"
#{
menu_selector
}
li"
).
last
.
click
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment