Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e11cb83a
Commit
e11cb83a
authored
Nov 04, 2020
by
Jason Goodman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove ci_send_deployment_hook_when_start feature flag
Enable deployment started webhook and chat notifications
parent
fe7d27c3
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
17 deletions
+0
-17
app/models/deployment.rb
app/models/deployment.rb
+0
-2
config/feature_flags/development/ci_send_deployment_hook_when_start.yml
..._flags/development/ci_send_deployment_hook_when_start.yml
+0
-7
spec/models/deployment_spec.rb
spec/models/deployment_spec.rb
+0
-8
No files found.
app/models/deployment.rb
View file @
e11cb83a
...
...
@@ -79,8 +79,6 @@ class Deployment < ApplicationRecord
after_transition
any
=>
:running
do
|
deployment
|
deployment
.
run_after_commit
do
next
unless
Feature
.
enabled?
(
:ci_send_deployment_hook_when_start
,
deployment
.
project
)
Deployments
::
ExecuteHooksWorker
.
perform_async
(
id
)
end
end
...
...
config/feature_flags/development/ci_send_deployment_hook_when_start.yml
deleted
100644 → 0
View file @
fe7d27c3
---
name
:
ci_send_deployment_hook_when_start
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41214
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/247137
group
:
group::progressive delivery
type
:
development
default_enabled
:
false
spec/models/deployment_spec.rb
View file @
e11cb83a
...
...
@@ -114,14 +114,6 @@ RSpec.describe Deployment do
deployment
.
run!
end
it
'does not execute Deployments::ExecuteHooksWorker when feature is disabled'
do
stub_feature_flags
(
ci_send_deployment_hook_when_start:
false
)
expect
(
Deployments
::
ExecuteHooksWorker
)
.
not_to
receive
(
:perform_async
).
with
(
deployment
.
id
)
deployment
.
run!
end
it
'executes Deployments::DropOlderDeploymentsWorker asynchronously'
do
expect
(
Deployments
::
DropOlderDeploymentsWorker
)
.
to
receive
(
:perform_async
).
once
.
with
(
deployment
.
id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment