Merge branch 'dz/351204-set-valid-quantity-on-purchase' into 'master'

Don't send empty string as quantity

See merge request gitlab-org/gitlab!79212

ee/app/assets/javascripts/subscriptions/buy_addons_shared/components/checkout/addon_purchase_details.vue

@@ -47,7 +47,7 @@ export default {
         return this.quantity || 0;
       },
       set(quantity) {
-        this.updateQuantity(quantity);
+        this.updateQuantity(quantity || 0);
       },
     },
     isValid() {

ee/app/assets/javascripts/subscriptions/buy_addons_shared/components/order_summary.vue

@@ -75,7 +75,7 @@ export default {
         logError(error);
       },
       skip() {
-        return !this.purchaseHasExpiration;
+        return !this.purchaseHasExpiration || !this.quantity;
       },
     },
   },

ee/spec/frontend/subscriptions/buy_addons_shared/components/order_summary_spec.js

@@ -32,6 +32,10 @@ describe('Order Summary', () => {
   const findAmount = () => wrapper.findByTestId('amount');
   const findTitle = () => wrapper.findByTestId('title');
 
+  const orderPreviewHandlerMock = jest
+    .fn()
+    .mockResolvedValue({ data: { orderPreview: mockOrderPreview } });
+
   const createMockApolloProvider = (stateData = {}, mockRequest = {}) => {
     const mockApollo = createMockApollo([], resolvers);
     const data = merge({}, mockStateData, initialStateData, stateData);
@@ -96,12 +100,9 @@ describe('Order Summary', () => {
   describe('when subscription has expiration date', () => {
     describe('calls api that returns prorated amount', () => {
       beforeEach(async () => {
-        const orderPreviewQueryMock = jest
-          .fn()
-          .mockResolvedValue({ data: { orderPreview: mockOrderPreview } });
         const apolloProvider = createMockApolloProvider(
           { subscription: { quantity: 1 } },
-          orderPreviewQueryMock,
+          orderPreviewHandlerMock,
         );
         createComponent(apolloProvider, { purchaseHasExpiration: true });
         await waitForPromises();
@@ -182,5 +183,19 @@ describe('Order Summary', () => {
         expect(findAmount().text()).toBe('-');
       });
     });
+
+    describe('when subscription quantity is 0', () => {
+      beforeEach(() => {
+        const apolloProvider = createMockApolloProvider(
+          { subscription: { quantity: 0 } },
+          orderPreviewHandlerMock,
+        );
+        createComponent(apolloProvider, { purchaseHasExpiration: true });
+      });
+
+      it('doesn not call api', () => {
+        expect(orderPreviewHandlerMock).not.toHaveBeenCalled();
+      });
+    });
   });
 });