Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e417781f
Commit
e417781f
authored
Jul 05, 2019
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Queue mirror update jobs in batches and wait for queue to drain
parent
815ebc83
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
4 deletions
+11
-4
app/workers/concerns/application_worker.rb
app/workers/concerns/application_worker.rb
+6
-0
ee/app/workers/update_all_mirrors_worker.rb
ee/app/workers/update_all_mirrors_worker.rb
+5
-4
No files found.
app/workers/concerns/application_worker.rb
View file @
e417781f
# frozen_string_literal: true
# frozen_string_literal: true
require
'sidekiq/api'
Sidekiq
::
Worker
.
extend
ActiveSupport
::
Concern
Sidekiq
::
Worker
.
extend
ActiveSupport
::
Concern
module
ApplicationWorker
module
ApplicationWorker
...
@@ -44,6 +46,10 @@ module ApplicationWorker
...
@@ -44,6 +46,10 @@ module ApplicationWorker
get_sidekiq_options
[
'queue'
].
to_s
get_sidekiq_options
[
'queue'
].
to_s
end
end
def
queue_size
Sidekiq
::
Queue
.
new
(
queue
).
size
end
def
bulk_perform_async
(
args_list
)
def
bulk_perform_async
(
args_list
)
Sidekiq
::
Client
.
push_bulk
(
'class'
=>
self
,
'args'
=>
args_list
)
Sidekiq
::
Client
.
push_bulk
(
'class'
=>
self
,
'args'
=>
args_list
)
end
end
...
...
ee/app/workers/update_all_mirrors_worker.rb
View file @
e417781f
...
@@ -7,7 +7,7 @@ class UpdateAllMirrorsWorker
...
@@ -7,7 +7,7 @@ class UpdateAllMirrorsWorker
LEASE_TIMEOUT
=
5
.
minutes
LEASE_TIMEOUT
=
5
.
minutes
SCHEDULE_WAIT_TIMEOUT
=
4
.
minutes
SCHEDULE_WAIT_TIMEOUT
=
4
.
minutes
LEASE_KEY
=
'update_all_mirrors'
.
freeze
LEASE_KEY
=
'update_all_mirrors'
.
freeze
RESCHEDULE_WAIT
=
1
0
.
seconds
RESCHEDULE_WAIT
=
1
.
second
def
perform
def
perform
return
if
Gitlab
::
Database
.
read_only?
return
if
Gitlab
::
Database
.
read_only?
...
@@ -37,7 +37,6 @@ class UpdateAllMirrorsWorker
...
@@ -37,7 +37,6 @@ class UpdateAllMirrorsWorker
# can't end up in an infinite loop
# can't end up in an infinite loop
now
=
Time
.
now
now
=
Time
.
now
last
=
nil
last
=
nil
all_project_ids
=
[]
while
capacity
>
0
while
capacity
>
0
batch_size
=
[
capacity
*
2
,
500
].
min
batch_size
=
[
capacity
*
2
,
500
].
min
...
@@ -47,7 +46,7 @@ class UpdateAllMirrorsWorker
...
@@ -47,7 +46,7 @@ class UpdateAllMirrorsWorker
project_ids
=
projects
.
lazy
.
select
(
&
:mirror?
).
take
(
capacity
).
map
(
&
:id
).
force
project_ids
=
projects
.
lazy
.
select
(
&
:mirror?
).
take
(
capacity
).
map
(
&
:id
).
force
capacity
-=
project_ids
.
length
capacity
-=
project_ids
.
length
all_project_ids
.
concat
(
project_ids
)
ProjectImportScheduleWorker
.
bulk_perform_async
(
project_ids
.
map
{
|
id
|
[
id
]
}
)
# If fewer than `batch_size` projects were returned, we don't need to query again
# If fewer than `batch_size` projects were returned, we don't need to query again
break
if
projects
.
length
<
batch_size
break
if
projects
.
length
<
batch_size
...
@@ -55,7 +54,9 @@ class UpdateAllMirrorsWorker
...
@@ -55,7 +54,9 @@ class UpdateAllMirrorsWorker
last
=
projects
.
last
.
import_state
.
next_execution_timestamp
last
=
projects
.
last
.
import_state
.
next_execution_timestamp
end
end
ProjectImportScheduleWorker
.
bulk_perform_and_wait
(
all_project_ids
.
map
{
|
id
|
[
id
]
},
timeout:
SCHEDULE_WAIT_TIMEOUT
.
to_i
)
# Wait for all ProjectImportScheduleWorker jobs to complete
deadline
=
Time
.
now
+
SCHEDULE_WAIT_TIMEOUT
sleep
1
while
ProjectImportScheduleWorker
.
queue_size
>
0
&&
Time
.
now
<
deadline
end
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: enable CodeReuse/ActiveRecord
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment