Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e614af0b
Commit
e614af0b
authored
Nov 01, 2018
by
Mark Lapierre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't log fabricate args
Prevents logging of sensitive data
parent
7f43b65f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
qa/qa/factory/base.rb
qa/qa/factory/base.rb
+1
-1
qa/spec/factory/base_spec.rb
qa/spec/factory/base_spec.rb
+3
-3
No files found.
qa/qa/factory/base.rb
View file @
e614af0b
...
@@ -100,7 +100,7 @@ module QA
...
@@ -100,7 +100,7 @@ module QA
msg
=
[
prefix
]
msg
=
[
prefix
]
msg
<<
"Built a
#{
name
}
"
msg
<<
"Built a
#{
name
}
"
msg
<<
"as a dependency of
#{
parents
.
last
}
"
if
parents
.
any?
msg
<<
"as a dependency of
#{
parents
.
last
}
"
if
parents
.
any?
msg
<<
"via
#{
method
}
with args
#{
args
}
"
msg
<<
"via
#{
method
}
"
yield
.
tap
do
yield
.
tap
do
msg
<<
"in
#{
Time
.
now
-
start
}
seconds"
msg
<<
"in
#{
Time
.
now
-
start
}
seconds"
...
...
qa/spec/factory/base_spec.rb
View file @
e614af0b
...
@@ -81,8 +81,8 @@ describe QA::Factory::Base do
...
@@ -81,8 +81,8 @@ describe QA::Factory::Base do
stub_env
(
'QA_DEBUG'
,
'true'
)
stub_env
(
'QA_DEBUG'
,
'true'
)
expect
(
factory
).
to
receive
(
:fabricate_via_api!
).
and_return
(
location
)
expect
(
factory
).
to
receive
(
:fabricate_via_api!
).
and_return
(
location
)
expect
{
subject
.
fabricate_via_api!
(
factory:
factory
,
parents:
[])
}
expect
{
subject
.
fabricate_via_api!
(
'something'
,
factory:
factory
,
parents:
[])
}
.
to
output
(
/==> Built a MyFactory via api
with args \[\] in [\d\w\.\-]
+/
)
.
to
output
(
/==> Built a MyFactory via api
in [\d\.\-e]+ seconds
+/
)
.
to_stdout
.
to_stdout
end
end
end
end
...
@@ -108,7 +108,7 @@ describe QA::Factory::Base do
...
@@ -108,7 +108,7 @@ describe QA::Factory::Base do
stub_env
(
'QA_DEBUG'
,
'true'
)
stub_env
(
'QA_DEBUG'
,
'true'
)
expect
{
subject
.
fabricate_via_browser_ui!
(
'something'
,
factory:
factory
,
parents:
[])
}
expect
{
subject
.
fabricate_via_browser_ui!
(
'something'
,
factory:
factory
,
parents:
[])
}
.
to
output
(
/==> Built a MyFactory via browser_ui
with args \["something"\] in [\d\w\.\-]
+/
)
.
to
output
(
/==> Built a MyFactory via browser_ui
in [\d\.\-e]+ seconds
+/
)
.
to_stdout
.
to_stdout
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment