Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e838de4e
Commit
e838de4e
authored
Jun 08, 2021
by
Scott Stern
Committed by
Etienne Baqué
Jun 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rm feature flag for epics filtered search [RUN ALL RSPEC] [RUN AS-IF-FOSS]
parent
adbbe982
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
3 additions
and
18 deletions
+3
-18
app/views/shared/issuable/_search_bar.html.haml
app/views/shared/issuable/_search_bar.html.haml
+1
-1
config/feature_flags/development/boards_filtered_search.yml
config/feature_flags/development/boards_filtered_search.yml
+0
-8
ee/app/assets/javascripts/epic_boards/index.js
ee/app/assets/javascripts/epic_boards/index.js
+2
-7
ee/app/controllers/groups/epic_boards_controller.rb
ee/app/controllers/groups/epic_boards_controller.rb
+0
-1
ee/spec/features/epic_boards/epic_boards_spec.rb
ee/spec/features/epic_boards/epic_boards_spec.rb
+0
-1
No files found.
app/views/shared/issuable/_search_bar.html.haml
View file @
e838de4e
...
@@ -23,7 +23,7 @@
...
@@ -23,7 +23,7 @@
-
checkbox_id
=
'check-all-issues'
-
checkbox_id
=
'check-all-issues'
%label
.gl-sr-only
{
for:
checkbox_id
}=
_
(
'Select all'
)
%label
.gl-sr-only
{
for:
checkbox_id
}=
_
(
'Select all'
)
=
check_box_tag
checkbox_id
,
nil
,
false
,
class:
"check-all-issues left"
=
check_box_tag
checkbox_id
,
nil
,
false
,
class:
"check-all-issues left"
-
if
Feature
.
enabled?
(
:boards_filtered_search
,
@group
)
&&
is_epic_board
-
if
is_epic_board
#js-board-filtered-search
{
data:
{
full_path:
@group
&
.
full_path
}
}
#js-board-filtered-search
{
data:
{
full_path:
@group
&
.
full_path
}
}
-
else
-
else
.issues-other-filters.filtered-search-wrapper.d-flex.flex-column.flex-md-row
.issues-other-filters.filtered-search-wrapper.d-flex.flex-column.flex-md-row
...
...
config/feature_flags/development/boards_filtered_search.yml
deleted
100644 → 0
View file @
adbbe982
---
name
:
boards_filtered_search
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/54641
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/322778
milestone
:
'
13.10'
type
:
development
group
:
group::project management
default_enabled
:
false
ee/app/assets/javascripts/epic_boards/index.js
View file @
e838de4e
...
@@ -7,6 +7,7 @@ import Vue from 'vue';
...
@@ -7,6 +7,7 @@ import Vue from 'vue';
import
VueApollo
from
'
vue-apollo
'
;
import
VueApollo
from
'
vue-apollo
'
;
import
{
mapActions
,
mapState
}
from
'
vuex
'
;
import
{
mapActions
,
mapState
}
from
'
vuex
'
;
import
initFilteredSearch
from
'
ee/boards/epic_filtered_search
'
;
import
{
fullEpicBoardId
,
transformBoardConfig
}
from
'
ee_component/boards/boards_util
'
;
import
{
fullEpicBoardId
,
transformBoardConfig
}
from
'
ee_component/boards/boards_util
'
;
import
BoardSidebar
from
'
ee_component/boards/components/board_sidebar
'
;
import
BoardSidebar
from
'
ee_component/boards/components/board_sidebar
'
;
import
toggleLabels
from
'
ee_component/boards/toggle_labels
'
;
import
toggleLabels
from
'
ee_component/boards/toggle_labels
'
;
...
@@ -55,13 +56,7 @@ export default () => {
...
@@ -55,13 +56,7 @@ export default () => {
}
}
});
});
if
(
gon
?.
features
?.
boardsFilteredSearch
)
{
import
(
'
ee/boards/epic_filtered_search
'
)
.
then
(({
default
:
initFilteredSearch
})
=>
{
initFilteredSearch
(
apolloProvider
);
initFilteredSearch
(
apolloProvider
);
})
.
catch
(()
=>
{});
}
// eslint-disable-next-line no-new
// eslint-disable-next-line no-new
new
Vue
({
new
Vue
({
...
...
ee/app/controllers/groups/epic_boards_controller.rb
View file @
e838de4e
...
@@ -10,7 +10,6 @@ class Groups::EpicBoardsController < Groups::ApplicationController
...
@@ -10,7 +10,6 @@ class Groups::EpicBoardsController < Groups::ApplicationController
before_action
:assign_endpoint_vars
before_action
:assign_endpoint_vars
before_action
do
before_action
do
push_frontend_feature_flag
(
:epic_boards
,
group
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:epic_boards
,
group
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:boards_filtered_search
,
group
)
end
end
track_redis_hll_event
:index
,
:show
,
name:
'g_project_management_users_viewing_epic_boards'
track_redis_hll_event
:index
,
:show
,
name:
'g_project_management_users_viewing_epic_boards'
...
...
ee/spec/features/epic_boards/epic_boards_spec.rb
View file @
e838de4e
...
@@ -214,7 +214,6 @@ RSpec.describe 'epic boards', :js do
...
@@ -214,7 +214,6 @@ RSpec.describe 'epic boards', :js do
context
'filtered search'
do
context
'filtered search'
do
before
do
before
do
stub_licensed_features
(
epics:
true
)
stub_licensed_features
(
epics:
true
)
stub_feature_flags
(
boards_filtered_search:
true
)
group
.
add_guest
(
user
)
group
.
add_guest
(
user
)
sign_in
(
user
)
sign_in
(
user
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment