Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e8a42677
Commit
e8a42677
authored
Aug 12, 2021
by
Matthias Käppler
Committed by
Marcin Sedlak-Jakubowski
Aug 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Set 36h limit for reviewer to respond when at capacity
parent
fd05a579
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
3 deletions
+4
-3
doc/development/code_review.md
doc/development/code_review.md
+4
-3
No files found.
doc/development/code_review.md
View file @
e8a42677
...
@@ -578,11 +578,12 @@ context is fresh in memory, and improves contributors' experience significantly.
...
@@ -578,11 +578,12 @@ context is fresh in memory, and improves contributors' experience significantly.
To ensure swift feedback to ready-to-review code, we maintain a
`Review-response`
Service-level Objective (SLO). The SLO is defined as:
To ensure swift feedback to ready-to-review code, we maintain a
`Review-response`
Service-level Objective (SLO). The SLO is defined as:
>
- review-response SLO = (time when first review response
is provided) - (time MR is assigned to reviewer) < 2 business days
>
Review-response SLO = (time when first review
is provided) - (time MR is assigned to reviewer) < 2 business days
If you don't think you can review a merge request in the
`Review-response`
SLO
If you don't think you can review a merge request in the
`Review-response`
SLO
time frame, let the author know as soon as possible and try to help them find
time frame, let the author know as soon as possible in the comments
another reviewer or maintainer who is able to, so that they can be unblocked
(no later than 36 hours after first receiving the review request)
and try to help them find another reviewer or maintainer who is able to, so that they can be unblocked
and get on with their work quickly. Remove yourself as a reviewer.
and get on with their work quickly. Remove yourself as a reviewer.
If you think you are at capacity and are unable to accept any more reviews until
If you think you are at capacity and are unable to accept any more reviews until
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment