Commit ea770985 authored by Dave Pisek's avatar Dave Pisek

Fix dismissed vulnerability comment updates

Context: We currently use two different data-sources for
displaying dismissal-feedback inside the vulnerability modal.

Within the MR-widget the data from the security-report is used
before the response from the vulnerability-feedback-endpoint.

The issue is that the security report endpoints are being cached,
so any changes to the dismissal comments are not reflected in the UI
until the cache is stale.

By using the data from the dedicated feedback-endpoint this can be
avoided.
parent bb40d720
......@@ -114,7 +114,9 @@ export default {
dismissalFeedback() {
return (
this.vulnerability &&
(this.vulnerability.dismissal_feedback || this.vulnerability.dismissalFeedback)
// grouped security reports are populating `dismissalFeedback` and the dashboards `dismissal_feedback`
// https://gitlab.com/gitlab-org/gitlab/issues/207489 aims to use the same property in all cases
(this.vulnerability.dismissalFeedback || this.vulnerability.dismissal_feedback)
);
},
isEditingExistingFeedback() {
......
---
title: Fix dismissed vulnerability comment updates
merge_request: 25328
author:
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment