Commit eb3e07a5 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Use project owner if no namespace. Restyled team page

parent 8bf340f5
...@@ -94,6 +94,7 @@ ...@@ -94,6 +94,7 @@
} }
input[type="text"] { input[type="text"] {
@extend .monospace;
border: 1px solid #BBB; border: 1px solid #BBB;
box-shadow: none; box-shadow: none;
margin-left: -1px; margin-left: -1px;
......
...@@ -18,7 +18,7 @@ class Ability ...@@ -18,7 +18,7 @@ class Ability
# Rules based on role in project # Rules based on role in project
if project.master_access_for?(user) if project.master_access_for?(user)
# TODO: replace with master rules. # TODO: replace with master rules.
# Only allow project administration for owners # Only allow project administration for namespace owners
rules << project_admin_rules rules << project_admin_rules
elsif project.dev_access_for?(user) elsif project.dev_access_for?(user)
...@@ -31,15 +31,20 @@ class Ability ...@@ -31,15 +31,20 @@ class Ability
rules << project_guest_rules rules << project_guest_rules
end end
# If user own project namespace (Ex. group owner or account owner) if project.namespace
if project.namespace && project.namespace.owner == user # If user own project namespace
# (Ex. group owner or account owner)
if project.namespace.owner == user
rules << project_admin_rules rules << project_admin_rules
end end
else
# If user was set as direct project owner # For compatibility with global projects
# use projects.owner_id
if project.owner == user if project.owner == user
rules << project_admin_rules rules << project_admin_rules
end end
end
rules.flatten rules.flatten
end end
......
...@@ -292,4 +292,8 @@ class Project < ActiveRecord::Base ...@@ -292,4 +292,8 @@ class Project < ActiveRecord::Base
merge_requests merge_requests
end end
end end
def namespace_owner
namespace.try(:owner)
end
end end
...@@ -24,10 +24,6 @@ ...@@ -24,10 +24,6 @@
= f.label :namespace_id = f.label :namespace_id
.input= f.select :namespace_id, namespaces_options(@project.namespace_id), {}, {class: 'chosen'} .input= f.select :namespace_id, namespaces_options(@project.namespace_id), {}, {class: 'chosen'}
.clearfix
= f.label :owner_id
.input= f.select :owner_id, User.all.map { |user| [user.name, user.id] }, {}, {class: 'chosen'}
- if project.repo_exists? - if project.repo_exists?
.clearfix .clearfix
= f.label :default_branch, "Default Branch" = f.label :default_branch, "Default Branch"
......
...@@ -25,6 +25,15 @@ ...@@ -25,6 +25,15 @@
Name: Name:
%td %td
= @project.name = @project.name
%tr
%td
%b
Namespace:
%td
- if @project.namespace
= @project.namespace.human_name
- else
Global
%tr %tr
%td %td
%b %b
...@@ -34,7 +43,7 @@ ...@@ -34,7 +43,7 @@
%tr %tr
%td %td
%b %b
Owner: Created by:
%td %td
= @project.owner_name || '(deleted)' = @project.owner_name || '(deleted)'
%tr %tr
......
...@@ -15,10 +15,6 @@ ...@@ -15,10 +15,6 @@
= image_tag gravatar_icon(user.email, 16), class: "avatar s16" = image_tag gravatar_icon(user.email, 16), class: "avatar s16"
%strong= user.name %strong= user.name
%span.cgray= user.email %span.cgray= user.email
- if @project
- if @project.owner == user
%span.btn.btn-small.disabled.right Project Owner
- else
- if @group.owner == user - if @group.owner == user
%span.btn.btn-small.disabled.right Group Owner %span.btn.btn-small.disabled.right Group Owner
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
%body{class: "#{app_theme} project"} %body{class: "#{app_theme} project"}
= render "layouts/flash" = render "layouts/flash"
= render "layouts/head_panel", title: @project.name = render "layouts/head_panel", title: @project.name
- if can?(current_user, :download_code, @project)
= render 'shared/no_ssh' = render 'shared/no_ssh'
.container .container
%ul.main_menu %ul.main_menu
......
= render 'clone_panel' = render 'clone_panel'
%div.git-empty %div.git-empty
%h4 Git global setup: %fieldset
%legend Git global setup:
%pre.dark %pre.dark
= preserve do = preserve do
git config --global user.name "#{current_user.name}" git config --global user.name "#{current_user.name}"
git config --global user.email "#{current_user.email}" git config --global user.email "#{current_user.email}"
%h4.prepend-top-20 Create Repository %fieldset
%legend Create Repository
%pre.dark %pre.dark
= preserve do = preserve do
mkdir #{@project.path} mkdir #{@project.path}
...@@ -19,7 +21,8 @@ ...@@ -19,7 +21,8 @@
git remote add origin #{@project.url_to_repo} git remote add origin #{@project.url_to_repo}
git push -u origin master git push -u origin master
%h4.prepend-top-20 Existing Git Repo? %fieldset
%legend Existing Git Repo?
%pre.dark %pre.dark
= preserve do = preserve do
cd existing_git_repo cd existing_git_repo
......
.input-prepend.project_clone_holder .input-prepend.project_clone_holder
%button{class: "btn active", :"data-clone" => @project.ssh_url_to_repo} SSH %button{class: "btn active", :"data-clone" => @project.ssh_url_to_repo} SSH
%button{class: "btn", :"data-clone" => @project.http_url_to_repo}= Gitlab.config.web_protocol.upcase %button{class: "btn", :"data-clone" => @project.http_url_to_repo}= Gitlab.config.web_protocol.upcase
= text_field_tag :project_clone, @project.url_to_repo, class: "one_click_select span5" = text_field_tag :project_clone, @project.url_to_repo, class: "one_click_select input-xxlarge"
- user = member.user - user = member.user
- allow_admin = can? current_user, :admin_project, @project - allow_admin = can? current_user, :admin_project, @project
%tr{id: dom_id(member), class: "team_member_row user_#{user.id}"} %li.wll{id: dom_id(member), class: "team_member_row user_#{user.id}"}
%td.span6 .row
.span6
= link_to project_team_member_path(@project, member), title: user.name, class: "dark" do = link_to project_team_member_path(@project, member), title: user.name, class: "dark" do
= image_tag gravatar_icon(user.email, 40), class: "avatar s32" = image_tag gravatar_icon(user.email, 40), class: "avatar s32"
= link_to project_team_member_path(@project, member), title: user.name, class: "dark" do = link_to project_team_member_path(@project, member), title: user.name, class: "dark" do
...@@ -9,11 +10,15 @@ ...@@ -9,11 +10,15 @@
%br %br
%small.cgray= user.email %small.cgray= user.email
%td.span5 .span5.right
- if allow_admin
.left
= form_for(member, as: :team_member, url: project_team_member_path(@project, member)) do |f|
= f.select :project_access, options_for_select(UsersProject.access_roles, member.project_access), {}, class: "medium project-access-select span2"
.right .right
- if current_user == user - if current_user == user
%span.btn.disabled This is you! %span.btn.disabled This is you!
- if @project.owner == user - if @project.namespace_owner == user
%span.btn.disabled.success Owner %span.btn.disabled.success Owner
- elsif user.blocked - elsif user.blocked
%span.btn.disabled.blocked Blocked %span.btn.disabled.blocked Blocked
...@@ -21,6 +26,3 @@ ...@@ -21,6 +26,3 @@
= link_to project_team_member_path(project_id: @project, id: member.id), confirm: remove_from_team_message(@project, member), method: :delete, class: "very_small btn danger" do = link_to project_team_member_path(project_id: @project, id: member.id), confirm: remove_from_team_message(@project, member), method: :delete, class: "very_small btn danger" do
%i.icon-minus.icon-white %i.icon-minus.icon-white
- if allow_admin
= form_for(member, as: :team_member, url: project_team_member_path(@project, member)) do |f|
= f.select :project_access, options_for_select(UsersProject.access_roles, member.project_access), {}, class: "medium project-access-select span2"
- grouper_project_members(@project).each do |access, members| - grouper_project_members(@project).each do |access, members|
%table.low %fieldset
%thead %legend
%tr
%th.span7
= Project.access_options.key(access).pluralize = Project.access_options.key(access).pluralize
%th %small= members.size
%tbody %ul.unstyled
- members.each do |up| - members.each do |up|
= render(partial: 'team_members/show', locals: {member: up}) = render(partial: 'team_members/show', locals: {member: up})
......
= render "projects/project_head" = render "projects/project_head"
%h3.page_title %h3.page_title
Team Members Team Members
%small (#{@project.users_projects.count}) (#{@project.users_projects.count})
%small
- if can? current_user, :admin_team_member, @project
%p.slead
Read more about project permissions Read more about project permissions
%strong= link_to "here", help_permissions_path, class: "vlink" %strong= link_to "here", help_permissions_path, class: "vlink"
- if can? current_user, :admin_team_member, @project
%span.right %span.right
= link_to import_project_team_members_path(@project), class: "btn small grouped", title: "Import team from another project" do = link_to import_project_team_members_path(@project), class: "btn small grouped", title: "Import team from another project" do
Import team from another project Import team from another project
= link_to new_project_team_member_path(@project), class: "btn success small grouped", title: "New Team Member" do = link_to new_project_team_member_path(@project), class: "btn success small grouped", title: "New Team Member" do
New Team Member New Team Member
%hr
.clearfix .clearfix
= render partial: "team_members/team", locals: {project: @project} %div.team-table
= render partial: "team_members/team", locals: {project: @project}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment