Reduce cognitive complexity of AlertsInserter

eb6b9e44 · syasonik · 4fde19a2 · eb6b9e44
Commit eb6b9e44 authored Apr 18, 2019 by syasonik
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

ee/lib/ee/gitlab/metrics_dashboard/stages/alerts_inserter.rb ee/lib/ee/gitlab/metrics_dashboard/stages/alerts_inserter.rb +2 -3

No files found.
--- a/ee/lib/ee/gitlab/metrics_dashboard/stages/alerts_inserter.rb
+++ b/ee/lib/ee/gitlab/metrics_dashboard/stages/alerts_inserter.rb
@@ -11,10 +11,9 @@ module EE
            alerts = metrics_with_alerts

            for_metrics do |metric|
-              next unless metric_id = metric[:metric_id]
-              next unless alerts.include?(metric_id)
+              next unless alerts.include?(metric[:metric_id])

-              metric[:alert_path] = alert_path(metric_id, project, environment)
+              metric[:alert_path] = alert_path(metric[:metric_id], project, environment)
            end
          end