Commit ee17fb03 authored by ddavison's avatar ddavison

Iteration for _field being the well-formed element

Since number fields, text boxes, text areas are editable
lets use _field as the vague descriptor
parent 43b35b6c
...@@ -59,9 +59,10 @@ We follow a simple formula roughly based on hungarian notation. ...@@ -59,9 +59,10 @@ We follow a simple formula roughly based on hungarian notation.
- `_link` - `_link`
- `_tab` - `_tab`
- `_dropdown` - `_dropdown`
- `_text` - `_field`
- `_checkbox` - `_checkbox`
- `_radio` - `_radio`
- `_content`
*Note: This list is a work in progress. This list will eventually be the end-all enumeration of all available types. *Note: This list is a work in progress. This list will eventually be the end-all enumeration of all available types.
I.e., any element that does not end with something in this list is bad form.* I.e., any element that does not end with something in this list is bad form.*
...@@ -74,18 +75,16 @@ view '...' do ...@@ -74,18 +75,16 @@ view '...' do
element :edit_button element :edit_button
element :notes_tab element :notes_tab
element :squash_checkbox element :squash_checkbox
element :username_field
element :issue_title_content
end end
``` ```
**Bad** **Bad**
```ruby ```ruby
view '...' do view '...' do
# `_field` should be `_text`. # `_confirmation` should be `_field`. what sort of confirmation? a checkbox confirmation? no real way to disambiguate.
# Per the W3C Spec, field is too vague. `type='password'`, `type='hidden'` etc. # an appropriate replacement would be `element :password_confirmation_field`
element :login_field
# `_confirmation` should be `_text`. what sort of confirmation? a checkbox confirmation? no real way to disambiguate.
# an appropriate replacement would be `element :password_confirmation_text`
element :password_confirmation element :password_confirmation
# `clone_options` is too vague. If it's a dropdown menu, it should be `clone_dropdown`. # `clone_options` is too vague. If it's a dropdown menu, it should be `clone_dropdown`.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment