Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
efcd4792
Commit
efcd4792
authored
Feb 28, 2018
by
Winnie Hellmann
Committed by
Connor Shea
Feb 28, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Forbid all inline script tags in Linter::InlineJavaScript
parent
c4bdfa92
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
lib/haml_lint/inline_javascript.rb
lib/haml_lint/inline_javascript.rb
+1
-1
No files found.
lib/haml_lint/inline_javascript.rb
View file @
efcd4792
...
@@ -8,7 +8,7 @@ unless Rails.env.production?
...
@@ -8,7 +8,7 @@ unless Rails.env.production?
include
LinterRegistry
include
LinterRegistry
def
visit_filter
(
node
)
def
visit_filter
(
node
)
return
unless
node
.
filter_type
==
'java
script'
return
unless
node
.
tag_name
==
'
script'
record_lint
(
node
,
'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)'
)
record_lint
(
node
,
'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)'
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment