Merge branch 'ah-eliminate-first-mentioned-in-commit-ff' into 'master'

Eliminate FF for first_mentioned_in_commit_at

See merge request gitlab-org/gitlab!28427

app/services/issues/close_service.rb

@@ -59,8 +59,6 @@ module Issues
     end
 
     def store_first_mentioned_in_commit_at(issue, merge_request)
-      return unless Feature.enabled?(:store_first_mentioned_in_commit_on_issue_close, issue.project, default_enabled: true)
-
       metrics = issue.metrics
       return if metrics.nil? || metrics.first_mentioned_in_commit_at
 

spec/services/issues/close_service_spec.rb

@@ -163,19 +163,6 @@ describe Issues::CloseService do
             expect(issue.metrics.first_mentioned_in_commit_at).to be_nil
           end
         end
-
-        context 'when `store_first_mentioned_in_commit_on_issue_close` feature flag is off' do
-          before do
-            stub_feature_flags(store_first_mentioned_in_commit_on_issue_close: { enabled: false, thing: issue.project })
-          end
-
-          it 'does not update the metrics' do
-            subject
-
-            expect(described_class).not_to receive(:store_first_mentioned_in_commit_at)
-            expect(issue.metrics.first_mentioned_in_commit_at).to be_nil
-          end
-        end
       end
     end