Minor maintainer review feedback

ee/app/assets/javascripts/analytics/cycle_analytics/components/base.vue

@@ -299,9 +299,7 @@ export default {
               />
             </template>
             <template v-if="customStageFormActive" #content>
-              <div v-if="isUpdatingCustomStage">
-                <gl-loading-icon class="mt-4" size="md" />
-              </div>
+              <gl-loading-icon v-if="isUpdatingCustomStage" class="mt-4" size="md" />
               <custom-stage-form
                 v-else
                 :events="formEvents"

ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js

@@ -123,7 +123,7 @@ export const receiveGroupStagesError = ({ commit }, error) => {
 
 export const setDefaultSelectedStage = ({ dispatch, getters }) => {
   const { activeStages = [] } = getters;
-  if (activeStages && activeStages.length) {
+  if (activeStages?.length) {
     const [firstActiveStage] = activeStages;
     return Promise.all([
       dispatch('setSelectedStage', firstActiveStage),

ee/app/assets/javascripts/analytics/cycle_analytics/store/modules/custom_stages/actions.js

 import Api from 'ee/api';
 import createFlash from '~/flash';
 import { __, sprintf } from '~/locale';
+import httpStatusCodes from '~/lib/utils/http_status';
 import * as types from './mutation_types';
 import { removeFlash, isStageNameExistsError } from '../../../utils';
 
@@ -48,7 +49,7 @@ export const receiveCreateStageSuccess = ({ commit, dispatch }, { data: { title
 
 export const receiveCreateStageError = (
   { commit, dispatch },
-  { status = 400, errors = {}, data = {} } = {},
+  { status = httpStatusCodes.BAD_REQUEST, errors = {}, data = {} } = {},
 ) => {
   commit(types.RECEIVE_CREATE_STAGE_ERROR);
   const { name = null } = data;
@@ -75,7 +76,7 @@ export const createStage = ({ dispatch, rootState }, data) => {
       return dispatch('receiveCreateStageSuccess', { status, data: responseData });
     })
     .catch(({ response } = {}) => {
-      const { data: { message, errors } = null, status = 400 } = response;
+      const { data: { message, errors } = null, status = httpStatusCodes.BAD_REQUEST } = response;
       dispatch('receiveCreateStageError', { data, message, errors, status });
     });
 };