Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f3943823
Commit
f3943823
authored
Sep 16, 2021
by
Alexander Turinske
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename popover trigger id computed value
- `iconId` => `popoverTriggerId` - it is more readable
parent
2109cef2
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
ee/app/assets/javascripts/approvals/components/approval_check_popover.vue
...vascripts/approvals/components/approval_check_popover.vue
+3
-3
No files found.
ee/app/assets/javascripts/approvals/components/approval_check_popover.vue
View file @
f3943823
...
@@ -30,7 +30,7 @@ export default {
...
@@ -30,7 +30,7 @@ export default {
},
},
},
},
computed
:
{
computed
:
{
icon
Id
()
{
popoverTrigger
Id
()
{
return
`reportInfo-
${
this
.
title
}
`
;
return
`reportInfo-
${
this
.
title
}
`
;
},
},
},
},
...
@@ -40,14 +40,14 @@ export default {
...
@@ -40,14 +40,14 @@ export default {
<
template
>
<
template
>
<span
class=
"vertical-align-middle text-muted js-help ml-2"
>
<span
class=
"vertical-align-middle text-muted js-help ml-2"
>
<gl-icon
<gl-icon
:id=
"
icon
Id"
:id=
"
popoverTrigger
Id"
name=
"question"
name=
"question"
class=
"author-link suggestion-help-hover"
class=
"author-link suggestion-help-hover"
:aria-label=
"__('help')"
:aria-label=
"__('help')"
:size=
"14"
:size=
"14"
data-testid=
"icon2"
data-testid=
"icon2"
/>
/>
<gl-popover
:target=
"
icon
Id"
placement=
"top"
:title=
"title"
>
<gl-popover
:target=
"
popoverTrigger
Id"
placement=
"top"
:title=
"title"
>
<div
class=
"mb-2"
>
{{
text
}}
</div>
<div
class=
"mb-2"
>
{{
text
}}
</div>
<gl-link
v-if=
"documentationLink"
target=
"_blank"
:href=
"documentationLink"
>
<gl-link
v-if=
"documentationLink"
target=
"_blank"
:href=
"documentationLink"
>
<span
class=
"vertical-align-middle"
>
{{
documentationText
}}
</span>
<span
class=
"vertical-align-middle"
>
{{
documentationText
}}
</span>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment