Commit f65a69a0 authored by allison.browne's avatar allison.browne Committed by Peter Leitzen

Remove feature flag for zoom quick actions

Zoom quick actions could be enabled via Feature.enable(
  :issue_zoom_integration
) or disabled via Feature.disable(:issue_zoom_integration).
This removes that ability and sets the feature to be enabled
by default
parent c26e40b1
...@@ -17,7 +17,7 @@ module Issues ...@@ -17,7 +17,7 @@ module Issues
end end
def can_add_link? def can_add_link?
available? && !link_in_issue_description? can? && !link_in_issue_description?
end end
def remove_link def remove_link
...@@ -29,7 +29,7 @@ module Issues ...@@ -29,7 +29,7 @@ module Issues
end end
def can_remove_link? def can_remove_link?
available? && link_in_issue_description? can? && link_in_issue_description?
end end
def parse_link(link) def parse_link(link)
...@@ -75,14 +75,6 @@ module Issues ...@@ -75,14 +75,6 @@ module Issues
issue_description[/(\S+)\z/, 1] issue_description[/(\S+)\z/, 1]
end end
def available?
feature_enabled? && can?
end
def feature_enabled?
Feature.enabled?(:issue_zoom_integration, project)
end
def can? def can?
current_user.can?(:update_issue, project) current_user.can?(:update_issue, project)
end end
......
...@@ -38,12 +38,6 @@ describe Issues::ZoomLinkService do ...@@ -38,12 +38,6 @@ describe Issues::ZoomLinkService do
end end
end end
shared_context 'feature flag disabled' do
before do
stub_feature_flags(issue_zoom_integration: false)
end
end
shared_context 'insufficient permissions' do shared_context 'insufficient permissions' do
before do before do
project.add_guest(user) project.add_guest(user)
...@@ -78,11 +72,6 @@ describe Issues::ZoomLinkService do ...@@ -78,11 +72,6 @@ describe Issues::ZoomLinkService do
include_examples 'cannot add link' include_examples 'cannot add link'
end end
context 'when feature flag is disabled' do
include_context 'feature flag disabled'
include_examples 'cannot add link'
end
context 'with insufficient permissions' do context 'with insufficient permissions' do
include_context 'insufficient permissions' include_context 'insufficient permissions'
include_examples 'cannot add link' include_examples 'cannot add link'
...@@ -113,12 +102,6 @@ describe Issues::ZoomLinkService do ...@@ -113,12 +102,6 @@ describe Issues::ZoomLinkService do
it { is_expected.to eq(true) } it { is_expected.to eq(true) }
context 'when feature flag is disabled' do
include_context 'feature flag disabled'
it { is_expected.to eq(false) }
end
context 'with insufficient permissions' do context 'with insufficient permissions' do
include_context 'insufficient permissions' include_context 'insufficient permissions'
...@@ -152,11 +135,6 @@ describe Issues::ZoomLinkService do ...@@ -152,11 +135,6 @@ describe Issues::ZoomLinkService do
.to eq(issue.description.delete_suffix("\n\n#{zoom_link}")) .to eq(issue.description.delete_suffix("\n\n#{zoom_link}"))
end end
context 'when feature flag is disabled' do
include_context 'feature flag disabled'
include_examples 'cannot remove link'
end
context 'with insufficient permissions' do context 'with insufficient permissions' do
include_context 'insufficient permissions' include_context 'insufficient permissions'
include_examples 'cannot remove link' include_examples 'cannot remove link'
...@@ -187,12 +165,6 @@ describe Issues::ZoomLinkService do ...@@ -187,12 +165,6 @@ describe Issues::ZoomLinkService do
it { is_expected.to eq(true) } it { is_expected.to eq(true) }
context 'when feature flag is disabled' do
include_context 'feature flag disabled'
it { is_expected.to eq(false) }
end
context 'with insufficient permissions' do context 'with insufficient permissions' do
include_context 'insufficient permissions' include_context 'insufficient permissions'
......
...@@ -45,14 +45,6 @@ shared_examples 'zoom quick actions' do ...@@ -45,14 +45,6 @@ shared_examples 'zoom quick actions' do
expect(page).to have_content('Failed to add a Zoom meeting') expect(page).to have_content('Failed to add a Zoom meeting')
expect(page).not_to have_content(zoom_link) expect(page).not_to have_content(zoom_link)
end end
context 'when feature flag disabled' do
before do
stub_feature_flags(issue_zoom_integration: false)
end
include_examples 'skip silently'
end
end end
context 'with Zoom link not at the end of the issue description' do context 'with Zoom link not at the end of the issue description' do
...@@ -92,14 +84,6 @@ shared_examples 'zoom quick actions' do ...@@ -92,14 +84,6 @@ shared_examples 'zoom quick actions' do
expect(page).to have_content('Zoom meeting removed') expect(page).to have_content('Zoom meeting removed')
expect(issue.reload.description).to eq("Text with #{zoom_link}") expect(issue.reload.description).to eq("Text with #{zoom_link}")
end end
context 'when feature flag disabled' do
before do
stub_feature_flags(issue_zoom_integration: false)
end
include_examples 'skip silently'
end
end end
context 'with a Zoom link not at the end of the description' do context 'with a Zoom link not at the end of the description' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment