Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fc3d44d1
Commit
fc3d44d1
authored
4 years ago
by
Scott Stern
Committed by
Ezekiel Kigbo
4 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Splits changed event with close and open in board_editable_item
parent
ad7b1241
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
4 deletions
+14
-4
app/assets/javascripts/boards/components/sidebar/board_editable_item.vue
...scripts/boards/components/sidebar/board_editable_item.vue
+2
-2
spec/frontend/boards/components/sidebar/board_editable_item_spec.js
...end/boards/components/sidebar/board_editable_item_spec.js
+12
-2
No files found.
app/assets/javascripts/boards/components/sidebar/board_editable_item.vue
View file @
fc3d44d1
...
@@ -36,7 +36,7 @@ export default {
...
@@ -36,7 +36,7 @@ export default {
}
}
this
.
edit
=
true
;
this
.
edit
=
true
;
this
.
$emit
(
'
changed
'
,
this
.
edit
);
this
.
$emit
(
'
open
'
);
window
.
addEventListener
(
'
click
'
,
this
.
collapseWhenOffClick
);
window
.
addEventListener
(
'
click
'
,
this
.
collapseWhenOffClick
);
},
},
collapse
()
{
collapse
()
{
...
@@ -45,7 +45,7 @@ export default {
...
@@ -45,7 +45,7 @@ export default {
}
}
this
.
edit
=
false
;
this
.
edit
=
false
;
this
.
$emit
(
'
c
hanged
'
,
this
.
edit
);
this
.
$emit
(
'
c
lose
'
);
window
.
removeEventListener
(
'
click
'
,
this
.
collapseWhenOffClick
);
window
.
removeEventListener
(
'
click
'
,
this
.
collapseWhenOffClick
);
},
},
},
},
...
...
This diff is collapsed.
Click to expand it.
spec/frontend/boards/components/sidebar/board_editable_item_spec.js
View file @
fc3d44d1
...
@@ -96,12 +96,22 @@ describe('boards sidebar remove issue', () => {
...
@@ -96,12 +96,22 @@ describe('boards sidebar remove issue', () => {
expect
(
findExpanded
().
isVisible
()).
toBe
(
false
);
expect
(
findExpanded
().
isVisible
()).
toBe
(
false
);
});
});
it
(
'
emits c
hanged
event
'
,
async
()
=>
{
it
(
'
emits c
lose
event
'
,
async
()
=>
{
document
.
body
.
click
();
document
.
body
.
click
();
await
wrapper
.
vm
.
$nextTick
();
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
emitted
().
c
hanged
[
1
][
0
]).
toBe
(
false
);
expect
(
wrapper
.
emitted
().
c
lose
.
length
).
toBe
(
1
);
});
});
});
});
it
(
'
emits open when edit button is clicked and edit is initailized to false
'
,
async
()
=>
{
createComponent
({
canUpdate
:
true
});
findEditButton
().
vm
.
$emit
(
'
click
'
);
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
emitted
().
open
.
length
).
toBe
(
1
);
});
});
});
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment