Merge branch 'add-pluck-primary-key' into 'master'

Add a thin encapsulation around .pluck(:id)

See merge request gitlab-org/gitlab-ce!26669

app/models/abuse_report.rb

 # frozen_string_literal: true
 
-class AbuseReport < ActiveRecord::Base
+class AbuseReport < ApplicationRecord
   include CacheMarkdownField
 
   cache_markdown_field :message, pipeline: :single_line

app/models/appearance.rb

 # frozen_string_literal: true
 
-class Appearance < ActiveRecord::Base
+class Appearance < ApplicationRecord
   include CacheableAttributes
   include CacheMarkdownField
   include ObjectStorage::BackgroundMove

app/models/application_record.rb

@@ -7,6 +7,14 @@ class ApplicationRecord < ActiveRecord::Base
     where(id: ids)
   end
 
+  def self.id_not_in(ids)
+    where.not(id: ids)
+  end
+
+  def self.pluck_primary_key
+    where(nil).pluck(self.primary_key)
+  end
+
   def self.safe_find_or_create_by!(*args)
     safe_find_or_create_by(*args).tap do |record|
       record.validate! unless record.persisted?

app/models/application_setting.rb

 # frozen_string_literal: true
 
-class ApplicationSetting < ActiveRecord::Base
+class ApplicationSetting < ApplicationRecord
   include CacheableAttributes
   include CacheMarkdownField
   include TokenAuthenticatable

app/models/application_setting/term.rb

 # frozen_string_literal: true
 
 class ApplicationSetting
-  class Term < ActiveRecord::Base
+  class Term < ApplicationRecord
     include CacheMarkdownField
     has_many :term_agreements
 

app/models/audit_event.rb

 # frozen_string_literal: true
 
-class AuditEvent < ActiveRecord::Base
+class AuditEvent < ApplicationRecord
   serialize :details, Hash # rubocop:disable Cop/ActiveRecordSerialize
 
   belongs_to :user, foreign_key: :author_id

app/models/award_emoji.rb

 # frozen_string_literal: true
 
-class AwardEmoji < ActiveRecord::Base
+class AwardEmoji < ApplicationRecord
   DOWNVOTE_NAME = "thumbsdown".freeze
   UPVOTE_NAME   = "thumbsup".freeze
 

app/models/badge.rb

 # frozen_string_literal: true
 
-class Badge < ActiveRecord::Base
+class Badge < ApplicationRecord
   include FromUnion
 
   # This structure sets the placeholders that the urls

app/models/board.rb

 # frozen_string_literal: true
 
-class Board < ActiveRecord::Base
+class Board < ApplicationRecord
   belongs_to :group
   belongs_to :project
 

app/models/board_group_recent_visit.rb

 # frozen_string_literal: true
 
 # Tracks which boards in a specific group a user has visited
-class BoardGroupRecentVisit < ActiveRecord::Base
+class BoardGroupRecentVisit < ApplicationRecord
   belongs_to :user
   belongs_to :group
   belongs_to :board

app/models/board_project_recent_visit.rb

 # frozen_string_literal: true
 
 # Tracks which boards in a specific project a user has visited
-class BoardProjectRecentVisit < ActiveRecord::Base
+class BoardProjectRecentVisit < ApplicationRecord
   belongs_to :user
   belongs_to :project
   belongs_to :board

app/models/broadcast_message.rb

 # frozen_string_literal: true
 
-class BroadcastMessage < ActiveRecord::Base
+class BroadcastMessage < ApplicationRecord
   include CacheMarkdownField
   include Sortable
 

app/models/chat_name.rb

 # frozen_string_literal: true
 
-class ChatName < ActiveRecord::Base
+class ChatName < ApplicationRecord
   LAST_USED_AT_INTERVAL = 1.hour
 
   belongs_to :service

app/models/chat_team.rb

 # frozen_string_literal: true
 
-class ChatTeam < ActiveRecord::Base
+class ChatTeam < ApplicationRecord
   validates :team_id, presence: true
   validates :namespace, uniqueness: true
 

app/models/ci/build_metadata.rb

@@ -3,7 +3,7 @@
 module Ci
   # The purpose of this class is to store Build related data that can be disposed.
   # Data that should be persisted forever, should be stored with Ci::Build model.
-  class BuildMetadata < ActiveRecord::Base
+  class BuildMetadata < ApplicationRecord
     extend Gitlab::Ci::Model
     include Presentable
     include ChronicDurationAttribute

app/models/ci/build_runner_session.rb

@@ -3,7 +3,7 @@
 module Ci
   # The purpose of this class is to store Build related runner session.
   # Data will be removed after transitioning from running to any state.
-  class BuildRunnerSession < ActiveRecord::Base
+  class BuildRunnerSession < ApplicationRecord
     extend Gitlab::Ci::Model
 
     self.table_name = 'ci_builds_runner_session'

app/models/ci/build_trace_chunk.rb

 # frozen_string_literal: true
 
 module Ci
-  class BuildTraceChunk < ActiveRecord::Base
+  class BuildTraceChunk < ApplicationRecord
     include FastDestroyAll
     include ::Gitlab::ExclusiveLeaseHelpers
     extend Gitlab::Ci::Model

app/models/ci/build_trace_section.rb

 # frozen_string_literal: true
 
 module Ci
-  class BuildTraceSection < ActiveRecord::Base
+  class BuildTraceSection < ApplicationRecord
     extend Gitlab::Ci::Model
 
     belongs_to :build, class_name: 'Ci::Build'

app/models/ci/build_trace_section_name.rb

 # frozen_string_literal: true
 
 module Ci
-  class BuildTraceSectionName < ActiveRecord::Base
+  class BuildTraceSectionName < ApplicationRecord
     extend Gitlab::Ci::Model
 
     belongs_to :project

app/models/ci/group_variable.rb

 # frozen_string_literal: true
 
 module Ci
-  class GroupVariable < ActiveRecord::Base
+  class GroupVariable < ApplicationRecord
     extend Gitlab::Ci::Model
     include HasVariable
     include Presentable

app/models/ci/job_artifact.rb

 # frozen_string_literal: true
 
 module Ci
-  class JobArtifact < ActiveRecord::Base
+  class JobArtifact < ApplicationRecord
     include AfterCommitQueue
     include ObjectStorage::BackgroundMove
     extend Gitlab::Ci::Model

app/models/ci/pipeline.rb

 # frozen_string_literal: true
 
 module Ci
-  class Pipeline < ActiveRecord::Base
+  class Pipeline < ApplicationRecord
     extend Gitlab::Ci::Model
     include HasStatus
     include Importable
@@ -184,7 +184,7 @@ module Ci
 
     scope :sort_by_merge_request_pipelines, -> do
       sql = 'CASE ci_pipelines.source WHEN (?) THEN 0 ELSE 1 END, ci_pipelines.id DESC'
-      query = ActiveRecord::Base.send(:sanitize_sql_array, [sql, sources[:merge_request_event]]) # rubocop:disable GitlabSecurity/PublicSend
+      query = ApplicationRecord.send(:sanitize_sql_array, [sql, sources[:merge_request_event]]) # rubocop:disable GitlabSecurity/PublicSend
 
       order(query)
     end

app/models/ci/pipeline_chat_data.rb

 # frozen_string_literal: true
 
 module Ci
-  class PipelineChatData < ActiveRecord::Base
+  class PipelineChatData < ApplicationRecord
     self.table_name = 'ci_pipeline_chat_data'
 
     belongs_to :chat_name

app/models/ci/pipeline_schedule.rb

 # frozen_string_literal: true
 
 module Ci
-  class PipelineSchedule < ActiveRecord::Base
+  class PipelineSchedule < ApplicationRecord
     extend Gitlab::Ci::Model
     include Importable
     include IgnorableColumn

app/models/ci/pipeline_schedule_variable.rb

 # frozen_string_literal: true
 
 module Ci
-  class PipelineScheduleVariable < ActiveRecord::Base
+  class PipelineScheduleVariable < ApplicationRecord
     extend Gitlab::Ci::Model
     include HasVariable
 

app/models/ci/pipeline_variable.rb

 # frozen_string_literal: true
 
 module Ci
-  class PipelineVariable < ActiveRecord::Base
+  class PipelineVariable < ApplicationRecord
     extend Gitlab::Ci::Model
     include HasVariable
 

app/models/ci/runner.rb

 # frozen_string_literal: true
 
 module Ci
-  class Runner < ActiveRecord::Base
+  class Runner < ApplicationRecord
     extend Gitlab::Ci::Model
     include Gitlab::SQL::Pattern
     include IgnorableColumn

app/models/ci/runner_namespace.rb

 # frozen_string_literal: true
 
 module Ci
-  class RunnerNamespace < ActiveRecord::Base
+  class RunnerNamespace < ApplicationRecord
     extend Gitlab::Ci::Model
 
     belongs_to :runner, inverse_of: :runner_namespaces, validate: true

app/models/ci/runner_project.rb

 # frozen_string_literal: true
 
 module Ci
-  class RunnerProject < ActiveRecord::Base
+  class RunnerProject < ApplicationRecord
     extend Gitlab::Ci::Model
 
     belongs_to :runner, inverse_of: :runner_projects

app/models/ci/stage.rb

 # frozen_string_literal: true
 
 module Ci
-  class Stage < ActiveRecord::Base
+  class Stage < ApplicationRecord
     extend Gitlab::Ci::Model
     include Importable
     include HasStatus

app/models/ci/trigger.rb

 # frozen_string_literal: true
 
 module Ci
-  class Trigger < ActiveRecord::Base
+  class Trigger < ApplicationRecord
     extend Gitlab::Ci::Model
     include IgnorableColumn
     include Presentable

app/models/ci/trigger_request.rb

 # frozen_string_literal: true
 
 module Ci
-  class TriggerRequest < ActiveRecord::Base
+  class TriggerRequest < ApplicationRecord
     extend Gitlab::Ci::Model
 
     belongs_to :trigger

app/models/ci/variable.rb

 # frozen_string_literal: true
 
 module Ci
-  class Variable < ActiveRecord::Base
+  class Variable < ApplicationRecord
     extend Gitlab::Ci::Model
     include HasVariable
     include Presentable

app/models/clusters/applications/cert_manager.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class CertManager < ActiveRecord::Base
+    class CertManager < ApplicationRecord
       VERSION = 'v0.5.2'.freeze
 
       self.table_name = 'clusters_applications_cert_managers'

app/models/clusters/applications/helm.rb

@@ -4,7 +4,7 @@ require 'openssl'
 
 module Clusters
   module Applications
-    class Helm < ActiveRecord::Base
+    class Helm < ApplicationRecord
       self.table_name = 'clusters_applications_helm'
 
       attr_encrypted :ca_key,

app/models/clusters/applications/ingress.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class Ingress < ActiveRecord::Base
+    class Ingress < ApplicationRecord
       VERSION = '1.1.2'.freeze
 
       self.table_name = 'clusters_applications_ingress'

app/models/clusters/applications/jupyter.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class Jupyter < ActiveRecord::Base
+    class Jupyter < ApplicationRecord
       VERSION = '0.9-174bbd5'.freeze
 
       self.table_name = 'clusters_applications_jupyter'

app/models/clusters/applications/knative.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class Knative < ActiveRecord::Base
+    class Knative < ApplicationRecord
       VERSION = '0.3.0'.freeze
       REPOSITORY = 'https://storage.googleapis.com/triggermesh-charts'.freeze
       METRICS_CONFIG = 'https://storage.googleapis.com/triggermesh-charts/istio-metrics.yaml'.freeze

app/models/clusters/applications/prometheus.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class Prometheus < ActiveRecord::Base
+    class Prometheus < ApplicationRecord
       include PrometheusAdapter
 
       VERSION = '6.7.3'

app/models/clusters/applications/runner.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Applications
-    class Runner < ActiveRecord::Base
+    class Runner < ApplicationRecord
       VERSION = '0.3.0'.freeze
 
       self.table_name = 'clusters_applications_runners'

app/models/clusters/cluster.rb

 # frozen_string_literal: true
 
 module Clusters
-  class Cluster < ActiveRecord::Base
+  class Cluster < ApplicationRecord
     include Presentable
     include Gitlab::Utils::StrongMemoize
     include FromUnion

app/models/clusters/group.rb

 # frozen_string_literal: true
 
 module Clusters
-  class Group < ActiveRecord::Base
+  class Group < ApplicationRecord
     self.table_name = 'cluster_groups'
 
     belongs_to :cluster, class_name: 'Clusters::Cluster'

app/models/clusters/kubernetes_namespace.rb

 # frozen_string_literal: true
 
 module Clusters
-  class KubernetesNamespace < ActiveRecord::Base
+  class KubernetesNamespace < ApplicationRecord
     include Gitlab::Kubernetes
 
     self.table_name = 'clusters_kubernetes_namespaces'

app/models/clusters/platforms/kubernetes.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Platforms
-    class Kubernetes < ActiveRecord::Base
+    class Kubernetes < ApplicationRecord
       include Gitlab::Kubernetes
       include ReactiveCaching
       include EnumWithNil

app/models/clusters/project.rb

 # frozen_string_literal: true
 
 module Clusters
-  class Project < ActiveRecord::Base
+  class Project < ApplicationRecord
     self.table_name = 'cluster_projects'
 
     belongs_to :cluster, class_name: 'Clusters::Cluster'

app/models/clusters/providers/gcp.rb

@@ -2,7 +2,7 @@
 
 module Clusters
   module Providers
-    class Gcp < ActiveRecord::Base
+    class Gcp < ApplicationRecord
       self.table_name = 'cluster_providers_gcp'
 
       belongs_to :cluster, inverse_of: :provider_gcp, class_name: 'Clusters::Cluster'

app/models/commit_status.rb

 # frozen_string_literal: true
 
-class CommitStatus < ActiveRecord::Base
+class CommitStatus < ApplicationRecord
   include HasStatus
   include Importable
   include AfterCommitQueue

app/models/concerns/atomic_internal_id.rb

@@ -7,7 +7,7 @@
 #
 # For example, let's generate internal ids for Issue per Project:
 # ```
-# class Issue < ActiveRecord::Base
+# class Issue < ApplicationRecord
 #   has_internal_id :iid, scope: :project, init: ->(s) { s.project.issues.maximum(:iid) }
 # end
 # ```

app/models/concerns/ignorable_column.rb

@@ -5,7 +5,7 @@
 #
 # Example:
 #
-#     class User < ActiveRecord::Base
+#     class User < ApplicationRecord
 #       include IgnorableColumn
 #
 #       ignore_column :updated_at

app/models/concerns/participable.rb

@@ -7,7 +7,7 @@
 #
 # Usage:
 #
-#     class Issue < ActiveRecord::Base
+#     class Issue < ApplicationRecord
 #       include Participable
 #
 #       # ...

app/models/concerns/reactive_caching.rb

@@ -7,7 +7,7 @@
 #
 # Example of use:
 #
-#    class Foo < ActiveRecord::Base
+#    class Foo < ApplicationRecord
 #      include ReactiveCaching
 #
 #      self.reactive_cache_key = ->(thing) { ["foo", thing.id] }

app/models/concerns/sha_attribute.rb

@@ -39,7 +39,7 @@ module ShaAttribute
     end
 
     def database_exists?
-      ActiveRecord::Base.connection
+      ApplicationRecord.connection
 
       true
     rescue

app/models/concerns/strip_attribute.rb

@@ -6,7 +6,7 @@
 #
 # Usage:
 #
-#     class Milestone < ActiveRecord::Base
+#     class Milestone < ApplicationRecord
 #       strip_attributes :title
 #     end
 #

app/models/container_repository.rb

 # frozen_string_literal: true
 
-class ContainerRepository < ActiveRecord::Base
+class ContainerRepository < ApplicationRecord
   include Gitlab::Utils::StrongMemoize
 
   belongs_to :project

app/models/conversational_development_index/metric.rb

 # frozen_string_literal: true
 
 module ConversationalDevelopmentIndex
-  class Metric < ActiveRecord::Base
+  class Metric < ApplicationRecord
     include Presentable
 
     self.table_name = 'conversational_development_index_metrics'

app/models/deploy_keys_project.rb

 # frozen_string_literal: true
 
-class DeployKeysProject < ActiveRecord::Base
+class DeployKeysProject < ApplicationRecord
   belongs_to :project
   belongs_to :deploy_key, inverse_of: :deploy_keys_projects
 

app/models/deploy_token.rb

 # frozen_string_literal: true
 
-class DeployToken < ActiveRecord::Base
+class DeployToken < ApplicationRecord
   include Expirable
   include TokenAuthenticatable
   include PolicyActor

app/models/deployment.rb

 # frozen_string_literal: true
 
-class Deployment < ActiveRecord::Base
+class Deployment < ApplicationRecord
   include AtomicInternalId
   include IidRoutes
   include AfterCommitQueue

app/models/email.rb

 # frozen_string_literal: true
 
-class Email < ActiveRecord::Base
+class Email < ApplicationRecord
   include Sortable
   include Gitlab::SQL::Pattern
 

app/models/environment.rb

 # frozen_string_literal: true
 
-class Environment < ActiveRecord::Base
+class Environment < ApplicationRecord
   include Gitlab::Utils::StrongMemoize
   # Used to generate random suffixes for the slug
   LETTERS = 'a'..'z'

app/models/epic.rb

@@ -2,7 +2,7 @@
 
 # Placeholder class for model that is implemented in EE
 # It reserves '&' as a reference prefix, but the table does not exists in CE
-class Epic < ActiveRecord::Base
+class Epic < ApplicationRecord
   def self.link_reference_pattern
     nil
   end

app/models/error_tracking/project_error_tracking_setting.rb

 # frozen_string_literal: true
 
 module ErrorTracking
-  class ProjectErrorTrackingSetting < ActiveRecord::Base
+  class ProjectErrorTrackingSetting < ApplicationRecord
     include Gitlab::Utils::StrongMemoize
     include ReactiveCaching
 

app/models/event.rb

 # frozen_string_literal: true
 
-class Event < ActiveRecord::Base
+class Event < ApplicationRecord
   include Sortable
   include IgnorableColumn
   include FromUnion

app/models/fork_network.rb

 # frozen_string_literal: true
 
-class ForkNetwork < ActiveRecord::Base
+class ForkNetwork < ApplicationRecord
   belongs_to :root_project, class_name: 'Project'
   has_many :fork_network_members
   has_many :projects, through: :fork_network_members

app/models/fork_network_member.rb

 # frozen_string_literal: true
 
-class ForkNetworkMember < ActiveRecord::Base
+class ForkNetworkMember < ApplicationRecord
   belongs_to :fork_network
   belongs_to :project
   belongs_to :forked_from_project, class_name: 'Project'

app/models/gpg_key.rb

 # frozen_string_literal: true
 
-class GpgKey < ActiveRecord::Base
+class GpgKey < ApplicationRecord
   KEY_PREFIX = '-----BEGIN PGP PUBLIC KEY BLOCK-----'.freeze
   KEY_SUFFIX = '-----END PGP PUBLIC KEY BLOCK-----'.freeze
 

app/models/gpg_key_subkey.rb

 # frozen_string_literal: true
 
-class GpgKeySubkey < ActiveRecord::Base
+class GpgKeySubkey < ApplicationRecord
   include ShaAttribute
 
   sha_attribute :keyid

app/models/group_custom_attribute.rb

 # frozen_string_literal: true
 
-class GroupCustomAttribute < ActiveRecord::Base
+class GroupCustomAttribute < ApplicationRecord
   belongs_to :group
 
   validates :group, :key, :value, presence: true

app/models/hooks/web_hook.rb

 # frozen_string_literal: true
 
-class WebHook < ActiveRecord::Base
+class WebHook < ApplicationRecord
   include Sortable
 
   attr_encrypted :token,

app/models/hooks/web_hook_log.rb

 # frozen_string_literal: true
 
-class WebHookLog < ActiveRecord::Base
+class WebHookLog < ApplicationRecord
   belongs_to :web_hook
 
   serialize :request_headers, Hash # rubocop:disable Cop/ActiveRecordSerialize

app/models/identity.rb

 # frozen_string_literal: true
 
-class Identity < ActiveRecord::Base
+class Identity < ApplicationRecord
   include Sortable
   include CaseSensitivity
 

app/models/identity/uniqueness_scopes.rb

 # frozen_string_literal: true
 
-class Identity < ActiveRecord::Base
+class Identity < ApplicationRecord
   # This module and method are defined in a separate file to allow EE to
   # redefine the `scopes` method before it is used in the `Identity` model.
   module UniquenessScopes

app/models/import_export_upload.rb

 # frozen_string_literal: true
 
-class ImportExportUpload < ActiveRecord::Base
+class ImportExportUpload < ApplicationRecord
   include WithUploads
   include ObjectStorage::BackgroundMove
 

app/models/internal_id.rb

@@ -15,7 +15,7 @@
 # In order to leverage InternalId for other usages, the idea is to
 # * Add `usage` value to enum
 # * (Optionally) add columns to `internal_ids` if needed for scope.
-class InternalId < ActiveRecord::Base
+class InternalId < ApplicationRecord
   belongs_to :project
   belongs_to :namespace
 

app/models/issue.rb

@@ -2,7 +2,7 @@
 
 require 'carrierwave/orm/activerecord'
 
-class Issue < ActiveRecord::Base
+class Issue < ApplicationRecord
   include AtomicInternalId
   include IidRoutes
   include Issuable

app/models/issue/metrics.rb

 # frozen_string_literal: true
 
-class Issue::Metrics < ActiveRecord::Base
+class Issue::Metrics < ApplicationRecord
   belongs_to :issue
 
   def record!

app/models/issue_assignee.rb

 # frozen_string_literal: true
 
-class IssueAssignee < ActiveRecord::Base
+class IssueAssignee < ApplicationRecord
   belongs_to :issue
   belongs_to :assignee, class_name: "User", foreign_key: :user_id
 end

app/models/key.rb

@@ -2,7 +2,7 @@
 
 require 'digest/md5'
 
-class Key < ActiveRecord::Base
+class Key < ApplicationRecord
   include AfterCommitQueue
   include Sortable
 

app/models/label.rb

 # frozen_string_literal: true
 
-class Label < ActiveRecord::Base
+class Label < ApplicationRecord
   include CacheMarkdownField
   include Referable
   include Subscribable

app/models/label_link.rb

 # frozen_string_literal: true
 
-class LabelLink < ActiveRecord::Base
+class LabelLink < ApplicationRecord
   include Importable
 
   belongs_to :target, polymorphic: true, inverse_of: :label_links # rubocop:disable Cop/PolymorphicAssociations

app/models/label_priority.rb

 # frozen_string_literal: true
 
-class LabelPriority < ActiveRecord::Base
+class LabelPriority < ApplicationRecord
   belongs_to :project
   belongs_to :label
 

app/models/lfs_file_lock.rb

 # frozen_string_literal: true
 
-class LfsFileLock < ActiveRecord::Base
+class LfsFileLock < ApplicationRecord
   belongs_to :project
   belongs_to :user
 

app/models/lfs_object.rb

 # frozen_string_literal: true
 
-class LfsObject < ActiveRecord::Base
+class LfsObject < ApplicationRecord
   include AfterCommitQueue
   include ObjectStorage::BackgroundMove
 

app/models/lfs_objects_project.rb

 # frozen_string_literal: true
 
-class LfsObjectsProject < ActiveRecord::Base
+class LfsObjectsProject < ApplicationRecord
   belongs_to :project
   belongs_to :lfs_object
 

app/models/list.rb

 # frozen_string_literal: true
 
-class List < ActiveRecord::Base
+class List < ApplicationRecord
   belongs_to :board
   belongs_to :label
 

app/models/member.rb

 # frozen_string_literal: true
 
-class Member < ActiveRecord::Base
+class Member < ApplicationRecord
   include AfterCommitQueue
   include Sortable
   include Importable

app/models/merge_request.rb

 # frozen_string_literal: true
 
-class MergeRequest < ActiveRecord::Base
+class MergeRequest < ApplicationRecord
   include AtomicInternalId
   include IidRoutes
   include Issuable

app/models/merge_request/metrics.rb

 # frozen_string_literal: true
 
-class MergeRequest::Metrics < ActiveRecord::Base
+class MergeRequest::Metrics < ApplicationRecord
   belongs_to :merge_request
   belongs_to :pipeline, class_name: 'Ci::Pipeline', foreign_key: :pipeline_id
   belongs_to :latest_closed_by, class_name: 'User'

app/models/merge_request_diff.rb

 # frozen_string_literal: true
 
-class MergeRequestDiff < ActiveRecord::Base
+class MergeRequestDiff < ApplicationRecord
   include Sortable
   include Importable
   include ManualInverseAssociation

app/models/merge_request_diff_commit.rb

 # frozen_string_literal: true
 
-class MergeRequestDiffCommit < ActiveRecord::Base
+class MergeRequestDiffCommit < ApplicationRecord
   include ShaAttribute
 
   belongs_to :merge_request_diff

app/models/merge_request_diff_file.rb

 # frozen_string_literal: true
 
-class MergeRequestDiffFile < ActiveRecord::Base
+class MergeRequestDiffFile < ApplicationRecord
   include Gitlab::EncodingHelper
   include DiffFile
 

app/models/merge_requests_closing_issues.rb

 # frozen_string_literal: true
 
-class MergeRequestsClosingIssues < ActiveRecord::Base
+class MergeRequestsClosingIssues < ApplicationRecord
   belongs_to :merge_request
   belongs_to :issue
 

app/models/milestone.rb

 # frozen_string_literal: true
 
-class Milestone < ActiveRecord::Base
+class Milestone < ApplicationRecord
   # Represents a "No Milestone" state used for filtering Issues and Merge
   # Requests that have no milestone assigned.
   MilestoneStruct = Struct.new(:title, :name, :id)

app/models/note.rb

@@ -3,7 +3,7 @@
 # A note on the root of an issue, merge request, commit, or snippet.
 #
 # A note of this type is never resolvable.
-class Note < ActiveRecord::Base
+class Note < ApplicationRecord
   extend ActiveModel::Naming
   include Participable
   include Mentionable

app/models/note_diff_file.rb

 # frozen_string_literal: true
 
-class NoteDiffFile < ActiveRecord::Base
+class NoteDiffFile < ApplicationRecord
   include DiffFile
 
   scope :for_commit_or_unresolved, -> do

app/models/notification_setting.rb

 # frozen_string_literal: true
 
-class NotificationSetting < ActiveRecord::Base
+class NotificationSetting < ApplicationRecord
   include IgnorableColumn
 
   ignore_column :events

app/models/pages_domain.rb

 # frozen_string_literal: true
 
-class PagesDomain < ActiveRecord::Base
+class PagesDomain < ApplicationRecord
   VERIFICATION_KEY = 'gitlab-pages-verification-code'.freeze
   VERIFICATION_THRESHOLD = 3.days.freeze
 

app/models/personal_access_token.rb

 # frozen_string_literal: true
 
-class PersonalAccessToken < ActiveRecord::Base
+class PersonalAccessToken < ApplicationRecord
   include Expirable
   include IgnorableColumn
   include TokenAuthenticatable

app/models/pool_repository.rb

@@ -3,7 +3,7 @@
 # The PoolRepository model is the database equivalent of an ObjectPool for Gitaly
 # That is; PoolRepository is the record in the database, ObjectPool is the
 # repository on disk
-class PoolRepository < ActiveRecord::Base
+class PoolRepository < ApplicationRecord
   include Shardable
   include AfterCommitQueue
 

app/models/postgresql/replication_slot.rb

 # frozen_string_literal: true
 
 module Postgresql
-  class ReplicationSlot < ActiveRecord::Base
+  class ReplicationSlot < ApplicationRecord
     self.table_name = 'pg_replication_slots'
 
     # Returns true if there are any replication slots in use.

app/models/programming_language.rb

 # frozen_string_literal: true
 
-class ProgrammingLanguage < ActiveRecord::Base
+class ProgrammingLanguage < ApplicationRecord
   validates :name, presence: true
   validates :color, allow_blank: false, color: true
 

app/models/project.rb

@@ -2,7 +2,7 @@
 
 require 'carrierwave/orm/activerecord'
 
-class Project < ActiveRecord::Base
+class Project < ApplicationRecord
   include Gitlab::ConfigHelper
   include Gitlab::ShellAdapter
   include Gitlab::VisibilityLevel

app/models/project_authorization.rb

 # frozen_string_literal: true
 
-class ProjectAuthorization < ActiveRecord::Base
+class ProjectAuthorization < ApplicationRecord
   include FromUnion
 
   belongs_to :user

app/models/project_auto_devops.rb

 # frozen_string_literal: true
 
-class ProjectAutoDevops < ActiveRecord::Base
+class ProjectAutoDevops < ApplicationRecord
   belongs_to :project
 
   enum deploy_strategy: {

app/models/project_ci_cd_setting.rb

 # frozen_string_literal: true
 
-class ProjectCiCdSetting < ActiveRecord::Base
+class ProjectCiCdSetting < ApplicationRecord
   belongs_to :project, inverse_of: :ci_cd_settings
 
   # The version of the schema that first introduced this model/table.

app/models/project_custom_attribute.rb

 # frozen_string_literal: true
 
-class ProjectCustomAttribute < ActiveRecord::Base
+class ProjectCustomAttribute < ApplicationRecord
   belongs_to :project
 
   validates :project, :key, :value, presence: true

app/models/project_daily_statistic.rb

 # frozen_string_literal: true
 
-class ProjectDailyStatistic < ActiveRecord::Base
+class ProjectDailyStatistic < ApplicationRecord
   belongs_to :project
 
   scope :of_project, -> (project) { where(project: project) }

app/models/project_deploy_token.rb

 # frozen_string_literal: true
 
-class ProjectDeployToken < ActiveRecord::Base
+class ProjectDeployToken < ApplicationRecord
   belongs_to :project
   belongs_to :deploy_token, inverse_of: :project_deploy_tokens
 

app/models/project_feature.rb

 # frozen_string_literal: true
 
-class ProjectFeature < ActiveRecord::Base
+class ProjectFeature < ApplicationRecord
   # == Project features permissions
   #
   # Grants access level to project tools

app/models/project_group_link.rb

 # frozen_string_literal: true
 
-class ProjectGroupLink < ActiveRecord::Base
+class ProjectGroupLink < ApplicationRecord
   include Expirable
 
   GUEST     = 10

app/models/project_import_data.rb

@@ -2,7 +2,7 @@
 
 require 'carrierwave/orm/activerecord'
 
-class ProjectImportData < ActiveRecord::Base
+class ProjectImportData < ApplicationRecord
   belongs_to :project, inverse_of: :import_data
   attr_encrypted :credentials,
                  key: Settings.attr_encrypted_db_key_base,

app/models/project_import_state.rb

 # frozen_string_literal: true
 
-class ProjectImportState < ActiveRecord::Base
+class ProjectImportState < ApplicationRecord
   include AfterCommitQueue
 
   self.table_name = "project_mirror_data"

app/models/project_repository.rb

 # frozen_string_literal: true
 
-class ProjectRepository < ActiveRecord::Base
+class ProjectRepository < ApplicationRecord
   include Shardable
 
   belongs_to :project, inverse_of: :project_repository

app/models/project_statistics.rb

 # frozen_string_literal: true
 
-class ProjectStatistics < ActiveRecord::Base
+class ProjectStatistics < ApplicationRecord
   belongs_to :project
   belongs_to :namespace
 

app/models/prometheus_metric.rb

 # frozen_string_literal: true
 
-class PrometheusMetric < ActiveRecord::Base
+class PrometheusMetric < ApplicationRecord
   belongs_to :project, validate: true, inverse_of: :prometheus_metrics
 
   enum group: {

app/models/protected_branch.rb

 # frozen_string_literal: true
 
-class ProtectedBranch < ActiveRecord::Base
+class ProtectedBranch < ApplicationRecord
   include ProtectedRef
 
   protected_ref_access_levels :merge, :push

app/models/protected_branch/merge_access_level.rb

 # frozen_string_literal: true
 
-class ProtectedBranch::MergeAccessLevel < ActiveRecord::Base
+class ProtectedBranch::MergeAccessLevel < ApplicationRecord
   include ProtectedBranchAccess
 end

app/models/protected_branch/push_access_level.rb

 # frozen_string_literal: true
 
-class ProtectedBranch::PushAccessLevel < ActiveRecord::Base
+class ProtectedBranch::PushAccessLevel < ApplicationRecord
   include ProtectedBranchAccess
 end

app/models/protected_tag.rb

 # frozen_string_literal: true
 
-class ProtectedTag < ActiveRecord::Base
+class ProtectedTag < ApplicationRecord
   include ProtectedRef
 
   validates :name, uniqueness: { scope: :project_id }

app/models/protected_tag/create_access_level.rb

 # frozen_string_literal: true
 
-class ProtectedTag::CreateAccessLevel < ActiveRecord::Base
+class ProtectedTag::CreateAccessLevel < ApplicationRecord
   include ProtectedTagAccess
 
   def check_access(user)

app/models/push_event_payload.rb

 # frozen_string_literal: true
 
-class PushEventPayload < ActiveRecord::Base
+class PushEventPayload < ApplicationRecord
   include ShaAttribute
 
   belongs_to :event, inverse_of: :push_event_payload

app/models/redirect_route.rb

 # frozen_string_literal: true
 
-class RedirectRoute < ActiveRecord::Base
+class RedirectRoute < ApplicationRecord
   belongs_to :source, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations
 
   validates :source, presence: true

app/models/release.rb

 # frozen_string_literal: true
 
-class Release < ActiveRecord::Base
+class Release < ApplicationRecord
   include CacheMarkdownField
   include Gitlab::Utils::StrongMemoize
 

app/models/releases/link.rb

 # frozen_string_literal: true
 
 module Releases
-  class Link < ActiveRecord::Base
+  class Link < ApplicationRecord
     self.table_name = 'release_links'
 
     belongs_to :release

app/models/remote_mirror.rb

 # frozen_string_literal: true
 
-class RemoteMirror < ActiveRecord::Base
+class RemoteMirror < ApplicationRecord
   include AfterCommitQueue
   include MirrorAuthentication
 

app/models/repository_language.rb

 # frozen_string_literal: true
 
-class RepositoryLanguage < ActiveRecord::Base
+class RepositoryLanguage < ApplicationRecord
   belongs_to :project
   belongs_to :programming_language
 

app/models/resource_label_event.rb

@@ -2,7 +2,7 @@
 
 # This model is not used yet, it will be used for:
 # https://gitlab.com/gitlab-org/gitlab-ce/issues/48483
-class ResourceLabelEvent < ActiveRecord::Base
+class ResourceLabelEvent < ApplicationRecord
   include Importable
   include Gitlab::Utils::StrongMemoize
   include CacheMarkdownField

app/models/route.rb

 # frozen_string_literal: true
 
-class Route < ActiveRecord::Base
+class Route < ApplicationRecord
   include CaseSensitivity
 
   belongs_to :source, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations

app/models/sent_notification.rb

 # frozen_string_literal: true
 
-class SentNotification < ActiveRecord::Base
+class SentNotification < ApplicationRecord
   serialize :position, Gitlab::Diff::Position # rubocop:disable Cop/ActiveRecordSerialize
 
   belongs_to :project

app/models/service.rb

@@ -2,7 +2,7 @@
 
 # To add new service you should build a class inherited from Service
 # and implement a set of methods
-class Service < ActiveRecord::Base
+class Service < ApplicationRecord
   include Sortable
   include Importable
   include ProjectServicesLoggable

app/models/shard.rb

 # frozen_string_literal: true
 
-class Shard < ActiveRecord::Base
+class Shard < ApplicationRecord
   # Store shard names from the configuration file in the database. This is not a
   # list of active shards - we just want to assign an immutable, unique ID to
   # every shard name for easy indexing / referencing.

app/models/snippet.rb

 # frozen_string_literal: true
 
-class Snippet < ActiveRecord::Base
+class Snippet < ApplicationRecord
   include Gitlab::VisibilityLevel
   include Redactable
   include CacheMarkdownField

app/models/spam_log.rb

 # frozen_string_literal: true
 
-class SpamLog < ActiveRecord::Base
+class SpamLog < ApplicationRecord
   belongs_to :user
 
   validates :user, presence: true

app/models/subscription.rb

 # frozen_string_literal: true
 
-class Subscription < ActiveRecord::Base
+class Subscription < ApplicationRecord
   belongs_to :user
   belongs_to :project
   belongs_to :subscribable, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations

app/models/system_note_metadata.rb

 # frozen_string_literal: true
 
-class SystemNoteMetadata < ActiveRecord::Base
+class SystemNoteMetadata < ApplicationRecord
   # These notes's action text might contain a reference that is external.
   # We should always force a deep validation upon references that are found
   # in this note type.

app/models/term_agreement.rb

 # frozen_string_literal: true
 
-class TermAgreement < ActiveRecord::Base
+class TermAgreement < ApplicationRecord
   belongs_to :term, class_name: 'ApplicationSetting::Term'
   belongs_to :user
 

app/models/timelog.rb

 # frozen_string_literal: true
 
-class Timelog < ActiveRecord::Base
+class Timelog < ApplicationRecord
   validates :time_spent, :user, presence: true
   validate :issuable_id_is_present
 

app/models/todo.rb

 # frozen_string_literal: true
 
-class Todo < ActiveRecord::Base
+class Todo < ApplicationRecord
   include Sortable
   include FromUnion
 

app/models/trending_project.rb

 # frozen_string_literal: true
 
-class TrendingProject < ActiveRecord::Base
+class TrendingProject < ApplicationRecord
   belongs_to :project
 
   # The number of months to include in the trending calculation.

app/models/u2f_registration.rb

@@ -2,7 +2,7 @@
 
 # Registration information for U2F (universal 2nd factor) devices, like Yubikeys
 
-class U2fRegistration < ActiveRecord::Base
+class U2fRegistration < ApplicationRecord
   belongs_to :user
 
   def self.register(user, app_id, params, challenges)

app/models/upload.rb

 # frozen_string_literal: true
 
-class Upload < ActiveRecord::Base
+class Upload < ApplicationRecord
   # Upper limit for foreground checksum processing
   CHECKSUM_THRESHOLD = 100.megabytes
 

app/models/user.rb

@@ -432,7 +432,7 @@ class User < ApplicationRecord
         fuzzy_arel_match(:name, query, lower_exact_match: true)
           .or(fuzzy_arel_match(:username, query, lower_exact_match: true))
           .or(arel_table[:email].eq(query))
-      ).reorder(order % { query: ActiveRecord::Base.connection.quote(query) }, :name)
+      ).reorder(order % { query: ApplicationRecord.connection.quote(query) }, :name)
     end
 
     # Limits the result set to users _not_ in the given query/list of IDs.

app/models/user_agent_detail.rb

 # frozen_string_literal: true
 
-class UserAgentDetail < ActiveRecord::Base
+class UserAgentDetail < ApplicationRecord
   belongs_to :subject, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations
 
   validates :user_agent, :ip_address, :subject_id, :subject_type, presence: true

app/models/user_callout.rb

 # frozen_string_literal: true
 
-class UserCallout < ActiveRecord::Base
+class UserCallout < ApplicationRecord
   belongs_to :user
 
   # We use `UserCalloutEnums.feature_names` here so that EE can more easily

app/models/user_custom_attribute.rb

 # frozen_string_literal: true
 
-class UserCustomAttribute < ActiveRecord::Base
+class UserCustomAttribute < ApplicationRecord
   belongs_to :user
 
   validates :user_id, :key, :value, presence: true

app/models/user_interacted_project.rb

 # frozen_string_literal: true
 
-class UserInteractedProject < ActiveRecord::Base
+class UserInteractedProject < ApplicationRecord
   belongs_to :user
   belongs_to :project
 

app/models/user_preference.rb

 # frozen_string_literal: true
 
-class UserPreference < ActiveRecord::Base
+class UserPreference < ApplicationRecord
   # We could use enums, but Rails 4 doesn't support multiple
   # enum options with same name for multiple fields, also it creates
   # extra methods that aren't really needed here.

app/models/user_status.rb

 # frozen_string_literal: true
 
-class UserStatus < ActiveRecord::Base
+class UserStatus < ApplicationRecord
   include CacheMarkdownField
 
   self.primary_key = :user_id

app/models/user_synced_attributes_metadata.rb

 # frozen_string_literal: true
 
-class UserSyncedAttributesMetadata < ActiveRecord::Base
+class UserSyncedAttributesMetadata < ApplicationRecord
   belongs_to :user
 
   validates :user, presence: true

app/models/users_star_project.rb

 # frozen_string_literal: true
 
-class UsersStarProject < ActiveRecord::Base
+class UsersStarProject < ApplicationRecord
   belongs_to :project, counter_cache: :star_count, touch: true
   belongs_to :user
 

app/services/issuable_base_service.rb

@@ -76,13 +76,11 @@ class IssuableBaseService < BaseService
     find_or_create_label_ids
   end
 
-  # rubocop: disable CodeReuse/ActiveRecord
   def filter_labels_in_param(key)
     return if params[key].to_a.empty?
 
-    params[key] = available_labels.where(id: params[key]).pluck(:id)
+    params[key] = available_labels.id_in(params[key]).pluck_primary_key
   end
-  # rubocop: enable CodeReuse/ActiveRecord
 
   def find_or_create_label_ids
     labels = params.delete(:labels)

app/services/merge_requests/delete_non_latest_diffs_service.rb

@@ -8,15 +8,13 @@ module MergeRequests
       @merge_request = merge_request
     end
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def execute
       diffs = @merge_request.non_latest_diffs.with_files
 
       diffs.each_batch(of: BATCH_SIZE) do |relation, index|
-        ids = relation.pluck(:id).map { |id| [id] }
+        ids = relation.pluck_primary_key.map { |id| [id] }
         DeleteDiffFilesWorker.bulk_perform_in(index * 5.minutes, ids)
       end
     end
-    # rubocop: enable CodeReuse/ActiveRecord
   end
 end

app/services/milestones/promote_service.rb

@@ -26,17 +26,15 @@ module Milestones
 
     private
 
-    # rubocop: disable CodeReuse/ActiveRecord
     def milestone_ids_for_merge(group_milestone)
       # Pluck need to be used here instead of select so the array of ids
       # is persistent after old milestones gets deleted.
       @milestone_ids_for_merge ||= begin
         search_params = { title: group_milestone.title, project_ids: group_project_ids, state: 'all' }
         milestones = MilestonesFinder.new(search_params).execute
-        milestones.pluck(:id)
+        milestones.pluck_primary_key
       end
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     def move_children_to_group_milestone(group_milestone)
       milestone_ids_for_merge(group_milestone).in_groups_of(100, false) do |milestone_ids|

app/services/quick_actions/interpret_service.rb

@@ -554,7 +554,7 @@ module QuickActions
         current_user.can?(:"update_#{issuable.to_ability_name}", issuable) &&
         issuable.project.boards.count == 1
     end
-    # rubocop: disable CodeReuse/ActiveRecord
+
     command :board_move do |target_list_name|
       label_ids = find_label_ids(target_list_name)
 
@@ -562,14 +562,17 @@ module QuickActions
         label_id = label_ids.first
 
         # Ensure this label corresponds to a list on the board
-        next unless Label.on_project_boards(issuable.project_id).where(id: label_id).exists?
+        next unless Label.on_project_boards(issuable.project_id).id_in(label_id).exists?
+
+        @updates[:remove_label_ids] = issuable
+            .labels
+            .on_project_boards(issuable.project_id)
+            .id_not_in(label_id)
+            .pluck_primary_key
 
-        @updates[:remove_label_ids] =
-          issuable.labels.on_project_boards(issuable.project_id).where.not(id: label_id).pluck(:id)
         @updates[:add_label_ids] = [label_id]
       end
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     desc 'Mark this issue as a duplicate of another issue'
     explanation do |duplicate_reference|