query.js: do not raise if the sort_on_option list is empty (!108) · Merge Requests · nexedi / jio

query.js: do not raise if the sort_on_option list is empty

Fix the error

Error: TypeError: Cannot read property '0' of undefined

when synchronizing officejs apps (see https://nexedijs.erp5.net/#/bug_module/20190227-23F861F)

I confirm the synchro works again by applying this page locally.

I couldn't find where in the code (neither in jio and in ERP5) the sort_on parameter set to []. Maybe it's done dynamically somewhere (in replicate storage ?).

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

Nicolas Wavrant @Nicolas commented Jun 27, 2019

Developer

@romain : what do you think of this MR ?

@romain : what do you think of this MR ?
Romain Courteaud @romain commented Jun 27, 2019

Owner

Please add a test to reproduce the issue to fix and ensure jslint passes.

Please add a test to reproduce the issue to fix and ensure jslint passes.
Nicolas Wavrant @Nicolas
added 1 commit

71e8158b - query.js: do not raise if the sort_on_option list is empty

Compare with previous version
Jun 28, 2019
added 1 commit

71e8158b - query.js: do not raise if the sort_on_option list is empty

Compare with previous version
added 1 commit * 71e8158b - query.js: do not raise if the sort_on_option list is empty [Compare with previous version](https://lab.nexedi.com/nexedi/jio/merge_requests/108/diffs?diff_id=9866&start_sha=287902e96a95793a3c8fd855f49e6ce7531d48c4)

Toggle commit list
Nicolas Wavrant @Nicolas commented Jun 28, 2019

Developer

Hi @romain ,

I pushed a test. I checked that without the fix in query.js this test raises.

Commits are already squashed. You can merge if you feel it is OK

Hi @romain , I pushed a test. I checked that without the fix in query.js this test raises. Commits are already squashed. You can merge if you feel it is OK
Romain Courteaud @romain
merged
Jun 28, 2019

merged

merged

Toggle commit list

Please register or sign in to comment

query.js: do not raise if the sort_on_option list is empty

Check out, review, and merge locally