query.js: do not raise if the sort_on_option list is empty (!108) · Merge Requests · nexedi / jio · GitLab

query.js: do not raise if the sort_on_option list is empty

Fix the error

Error: TypeError: Cannot read property '0' of undefined

when synchronizing officejs apps (see https://nexedijs.erp5.net/#/bug_module/20190227-23F861F)

I confirm the synchro works again by applying this page locally.

I couldn't find where in the code (neither in jio and in ERP5) the sort_on parameter set to []. Maybe it's done dynamically somewhere (in replicate storage ?).

Edited 2019-06-28 13:35:18 UTC

Request to merge Nicolas:fix-officejs-synchro into master

Discussion 3
Commits 1
Changes 2
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

@Nicolas Nicolas Wavrant
@Nicolas commented 2019-06-27 04:42:20 UTC

Developer

@romain : what do you think of this MR ?
@romain Romain Courteaud
@romain commented 2019-06-27 07:08:19 UTC

Owner

Please add a test to reproduce the issue to fix and ensure jslint passes.
@Nicolas Nicolas Wavrant
@Nicolas
added 1 commit

71e8158b - query.js: do not raise if the sort_on_option list is empty

Compare with previous version
2019-06-28 07:11:10 UTC
added 1 commit

71e8158b - query.js: do not raise if the sort_on_option list is empty

Compare with previous version
Toggle commit list
@Nicolas Nicolas Wavrant
@Nicolas commented 2019-06-28 07:12:24 UTC

Developer

Hi @romain ,

I pushed a test. I checked that without the fix in query.js this test raises.

Commits are already squashed. You can merge if you feel it is OK
@romain Romain Courteaud
@romain
merged
2019-06-28 13:35:18 UTC

merged

Toggle commit list

Please register or sign in to post a comment