Commit 002a5abb authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman

staging: unisys: visorbus: add error handling to toolaction_show

Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reviewed-by: default avatarReviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent deeeca6d
......@@ -91,10 +91,15 @@ static ssize_t toolaction_show(struct device *dev,
char *buf)
{
u8 tool_action = 0;
int err;
visorchannel_read(chipset_dev->controlvm_channel,
err = visorchannel_read(chipset_dev->controlvm_channel,
offsetof(struct spar_controlvm_channel_protocol,
tool_action), &tool_action, sizeof(u8));
tool_action),
&tool_action, sizeof(u8));
if (err)
return err;
return sprintf(buf, "%u\n", tool_action);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment