Commit 01bf9278 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Russell King

ARM: 8623/1: mm: add ARM_L1_CACHE_SHIFT_7 for UniPhier outer cache

The UniPhier outer cache (arch/arm/mm/cache-uniphier.c) has 128 byte
line length and its tags are also managed per 128 byte line.  This
is very unfortunate, but the current 64 byte alignment for kmalloc()
causes sharing problems on DMA if used with this outer cache.

This commit adds ARM_L1_CACHE_SHIFT_7 to increase the DMA minimum
alignment to 128 byte if CACHE_UNIPHIER is enabled.  There are
several drivers that assume aligning to L1_CACHE_BYTES will be DMA
safe, so this commit also changes the L1_CACHE_BYTES for safety.

Having said that, I hesitate to align all the other SoCs in Multi
platform to the UniPhier's requirement.  So, I am disabling the
CONFIG_CACHE_UNIPHIER by default, so that multi_v7_defconfig will
still stay with CONFIG_ARM_L1_CACHE_SHIFT=6.  With this commit,
UniPhier SoCs will become slower, but it is much better than system
crash.  If desired, the outer-cache can be enabled by merge_config
or something.

Note:
The UniPhier PH1-Pro5 SoC is equipped also with L3 cache with 256
byte line size but its tags are managed per 128 byte sub-line.
So, ARM_L1_CACHE_SHIFT_7 should be fine for all the UniPhier SoCs.
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent ffa5d3ee
...@@ -991,7 +991,7 @@ config CACHE_TAUROS2 ...@@ -991,7 +991,7 @@ config CACHE_TAUROS2
config CACHE_UNIPHIER config CACHE_UNIPHIER
bool "Enable the UniPhier outer cache controller" bool "Enable the UniPhier outer cache controller"
depends on ARCH_UNIPHIER depends on ARCH_UNIPHIER
default y select ARM_L1_CACHE_SHIFT_7
select OUTER_CACHE select OUTER_CACHE
select OUTER_CACHE_SYNC select OUTER_CACHE_SYNC
help help
...@@ -1012,8 +1012,14 @@ config ARM_L1_CACHE_SHIFT_6 ...@@ -1012,8 +1012,14 @@ config ARM_L1_CACHE_SHIFT_6
help help
Setting ARM L1 cache line size to 64 Bytes. Setting ARM L1 cache line size to 64 Bytes.
config ARM_L1_CACHE_SHIFT_7
bool
help
Setting ARM L1 cache line size to 128 Bytes.
config ARM_L1_CACHE_SHIFT config ARM_L1_CACHE_SHIFT
int int
default 7 if ARM_L1_CACHE_SHIFT_7
default 6 if ARM_L1_CACHE_SHIFT_6 default 6 if ARM_L1_CACHE_SHIFT_6
default 5 default 5
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment