Commit 04b7d41d authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller

net: ethernet: Fix up drivers masking pause support

PHY drivers don't indicate they support pause. They expect MAC drivers
to enable its support if the MAC has the needed hardware. Thus MAC
drivers should not mask Pause support, but enable it.

Change a few ANDs to ORs.
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00eb2243
...@@ -2123,14 +2123,14 @@ static int tg3_phy_init(struct tg3 *tp) ...@@ -2123,14 +2123,14 @@ static int tg3_phy_init(struct tg3 *tp)
case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII:
if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) { if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) {
phy_set_max_speed(phydev, SPEED_1000); phy_set_max_speed(phydev, SPEED_1000);
phydev->supported &= (SUPPORTED_Pause | phydev->supported |= (SUPPORTED_Pause |
SUPPORTED_Asym_Pause); SUPPORTED_Asym_Pause);
break; break;
} }
/* fallthru */ /* fallthru */
case PHY_INTERFACE_MODE_MII: case PHY_INTERFACE_MODE_MII:
phy_set_max_speed(phydev, SPEED_100); phy_set_max_speed(phydev, SPEED_100);
phydev->supported &= (SUPPORTED_Pause | phydev->supported |= (SUPPORTED_Pause |
SUPPORTED_Asym_Pause); SUPPORTED_Asym_Pause);
break; break;
default: default:
......
...@@ -10,8 +10,6 @@ ...@@ -10,8 +10,6 @@
#define HCLGE_PHY_SUPPORTED_FEATURES (SUPPORTED_Autoneg | \ #define HCLGE_PHY_SUPPORTED_FEATURES (SUPPORTED_Autoneg | \
SUPPORTED_TP | \ SUPPORTED_TP | \
SUPPORTED_Pause | \
SUPPORTED_Asym_Pause | \
PHY_10BT_FEATURES | \ PHY_10BT_FEATURES | \
PHY_100BT_FEATURES | \ PHY_100BT_FEATURES | \
PHY_1000BT_FEATURES) PHY_1000BT_FEATURES)
...@@ -213,6 +211,8 @@ int hclge_mac_connect_phy(struct hclge_dev *hdev) ...@@ -213,6 +211,8 @@ int hclge_mac_connect_phy(struct hclge_dev *hdev)
} }
phydev->supported &= HCLGE_PHY_SUPPORTED_FEATURES; phydev->supported &= HCLGE_PHY_SUPPORTED_FEATURES;
phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
phydev->advertising = phydev->supported; phydev->advertising = phydev->supported;
return 0; return 0;
......
...@@ -360,7 +360,7 @@ static int mtk_phy_connect(struct net_device *dev) ...@@ -360,7 +360,7 @@ static int mtk_phy_connect(struct net_device *dev)
SUPPORTED_Pause | SUPPORTED_Asym_Pause; SUPPORTED_Pause | SUPPORTED_Asym_Pause;
phy_set_max_speed(dev->phydev, SPEED_1000); phy_set_max_speed(dev->phydev, SPEED_1000);
dev->phydev->supported &= SUPPORTED_Pause | SUPPORTED_Asym_Pause; dev->phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
dev->phydev->advertising = dev->phydev->supported | dev->phydev->advertising = dev->phydev->supported |
ADVERTISED_Autoneg; ADVERTISED_Autoneg;
phy_start_aneg(dev->phydev); phy_start_aneg(dev->phydev);
......
...@@ -1051,7 +1051,7 @@ static int smsc911x_mii_probe(struct net_device *dev) ...@@ -1051,7 +1051,7 @@ static int smsc911x_mii_probe(struct net_device *dev)
phy_set_max_speed(phydev, SPEED_100); phy_set_max_speed(phydev, SPEED_100);
/* mask with MAC supported features */ /* mask with MAC supported features */
phydev->supported &= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause);
phydev->advertising = phydev->supported; phydev->advertising = phydev->supported;
pdata->last_duplex = -1; pdata->last_duplex = -1;
......
...@@ -1138,7 +1138,7 @@ static int smsc9420_mii_probe(struct net_device *dev) ...@@ -1138,7 +1138,7 @@ static int smsc9420_mii_probe(struct net_device *dev)
phy_set_max_speed(phydev, SPEED_100); phy_set_max_speed(phydev, SPEED_100);
/* mask with MAC supported features */ /* mask with MAC supported features */
phydev->supported &= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause);
phydev->advertising = phydev->supported; phydev->advertising = phydev->supported;
phy_attached_info(phydev); phy_attached_info(phydev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment