Commit 07b61991 authored by Lorenz Bauer's avatar Lorenz Bauer Committed by Alexei Starovoitov

selftests: bpf: initialize bpf_object pointers where needed

There are a few tests which call bpf_object__close on uninitialized
bpf_object*, which may segfault. Explicitly zero-initialise these pointers
to avoid this.
Signed-off-by: default avatarLorenz Bauer <lmb@cloudflare.com>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 494bc1d2
...@@ -15,7 +15,7 @@ static int libbpf_debug_print(enum libbpf_print_level level, ...@@ -15,7 +15,7 @@ static int libbpf_debug_print(enum libbpf_print_level level,
static int check_load(const char *file) static int check_load(const char *file)
{ {
struct bpf_prog_load_attr attr; struct bpf_prog_load_attr attr;
struct bpf_object *obj; struct bpf_object *obj = NULL;
int err, prog_fd; int err, prog_fd;
memset(&attr, 0, sizeof(struct bpf_prog_load_attr)); memset(&attr, 0, sizeof(struct bpf_prog_load_attr));
......
...@@ -9,7 +9,7 @@ static void test_task_fd_query_tp_core(const char *probe_name, ...@@ -9,7 +9,7 @@ static void test_task_fd_query_tp_core(const char *probe_name,
struct perf_event_attr attr = {}; struct perf_event_attr attr = {};
__u64 probe_offset, probe_addr; __u64 probe_offset, probe_addr;
__u32 len, prog_id, fd_type; __u32 len, prog_id, fd_type;
struct bpf_object *obj; struct bpf_object *obj = NULL;
__u32 duration = 0; __u32 duration = 0;
char buf[256]; char buf[256];
......
...@@ -13,6 +13,9 @@ void test_tp_attach_query(void) ...@@ -13,6 +13,9 @@ void test_tp_attach_query(void)
struct bpf_prog_info prog_info; struct bpf_prog_info prog_info;
char buf[256]; char buf[256];
for (i = 0; i < num_progs; i++)
obj[i] = NULL;
snprintf(buf, sizeof(buf), snprintf(buf, sizeof(buf),
"/sys/kernel/debug/tracing/events/sched/sched_switch/id"); "/sys/kernel/debug/tracing/events/sched/sched_switch/id");
efd = open(buf, O_RDONLY, 0); efd = open(buf, O_RDONLY, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment