Commit 0b294aeb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo

ath11k: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200727194415.GA1275@embeddedor
parent 28f16321
...@@ -729,7 +729,7 @@ static void ath11k_core_restart(struct work_struct *work) ...@@ -729,7 +729,7 @@ static void ath11k_core_restart(struct work_struct *work)
break; break;
case ATH11K_STATE_RESTARTED: case ATH11K_STATE_RESTARTED:
ar->state = ATH11K_STATE_WEDGED; ar->state = ATH11K_STATE_WEDGED;
/* fall through */ fallthrough;
case ATH11K_STATE_WEDGED: case ATH11K_STATE_WEDGED:
ath11k_warn(ab, ath11k_warn(ab,
"device is wedged, will not restart radio %d\n", i); "device is wedged, will not restart radio %d\n", i);
......
...@@ -268,7 +268,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring, ...@@ -268,7 +268,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring,
break; break;
} }
/* follow through when ring_num >= 3 */ /* follow through when ring_num >= 3 */
/* fall through */ fallthrough;
case HAL_REO_EXCEPTION: case HAL_REO_EXCEPTION:
case HAL_REO_REINJECT: case HAL_REO_REINJECT:
case HAL_REO_CMD: case HAL_REO_CMD:
......
...@@ -3782,8 +3782,7 @@ static bool ath11k_dp_rx_h_reo_err(struct ath11k *ar, struct sk_buff *msdu, ...@@ -3782,8 +3782,7 @@ static bool ath11k_dp_rx_h_reo_err(struct ath11k *ar, struct sk_buff *msdu,
* instead, it is good to drop such packets in mac80211 * instead, it is good to drop such packets in mac80211
* after incrementing the replay counters. * after incrementing the replay counters.
*/ */
fallthrough;
/* fall through */
default: default:
/* TODO: Review other errors and process them to mac80211 /* TODO: Review other errors and process them to mac80211
* as appropriate. * as appropriate.
......
...@@ -1146,13 +1146,13 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set, ...@@ -1146,13 +1146,13 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set,
idx_limit = -1; idx_limit = -1;
switch (idx_limit) { switch (idx_limit) {
case 0: /* fall through */ case 0:
case 1: /* fall through */ case 1:
case 2: /* fall through */ case 2:
case 3: /* fall through */ case 3:
case 4: /* fall through */ case 4:
case 5: /* fall through */ case 5:
case 6: /* fall through */ case 6:
case 7: case 7:
mcs = IEEE80211_VHT_MCS_SUPPORT_0_7; mcs = IEEE80211_VHT_MCS_SUPPORT_0_7;
break; break;
...@@ -1164,7 +1164,7 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set, ...@@ -1164,7 +1164,7 @@ ath11k_peer_assoc_h_vht_limit(u16 tx_mcs_set,
break; break;
default: default:
WARN_ON(1); WARN_ON(1);
/* fall through */ fallthrough;
case -1: case -1:
mcs = IEEE80211_VHT_MCS_NOT_SUPPORTED; mcs = IEEE80211_VHT_MCS_NOT_SUPPORTED;
break; break;
...@@ -1347,7 +1347,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar, ...@@ -1347,7 +1347,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar,
arg->peer_he_tx_mcs_set[WMI_HECAP_TXRX_MCS_NSS_IDX_160] = v; arg->peer_he_tx_mcs_set[WMI_HECAP_TXRX_MCS_NSS_IDX_160] = v;
arg->peer_he_mcs_count++; arg->peer_he_mcs_count++;
/* fall through */ fallthrough;
default: default:
v = le16_to_cpu(he_cap->he_mcs_nss_supp.rx_mcs_80); v = le16_to_cpu(he_cap->he_mcs_nss_supp.rx_mcs_80);
...@@ -2122,7 +2122,7 @@ void __ath11k_mac_scan_finish(struct ath11k *ar) ...@@ -2122,7 +2122,7 @@ void __ath11k_mac_scan_finish(struct ath11k *ar)
} else if (ar->scan.roc_notify) { } else if (ar->scan.roc_notify) {
ieee80211_remain_on_channel_expired(ar->hw); ieee80211_remain_on_channel_expired(ar->hw);
} }
/* fall through */ fallthrough;
case ATH11K_SCAN_STARTING: case ATH11K_SCAN_STARTING:
ar->scan.state = ATH11K_SCAN_IDLE; ar->scan.state = ATH11K_SCAN_IDLE;
ar->scan_channel = NULL; ar->scan_channel = NULL;
...@@ -4383,7 +4383,7 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw, ...@@ -4383,7 +4383,7 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
break; break;
case NL80211_IFTYPE_MESH_POINT: case NL80211_IFTYPE_MESH_POINT:
arvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S; arvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S;
/* fall through */ fallthrough;
case NL80211_IFTYPE_AP: case NL80211_IFTYPE_AP:
arvif->vdev_type = WMI_VDEV_TYPE_AP; arvif->vdev_type = WMI_VDEV_TYPE_AP;
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment