Commit 0d0659c7 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

arch/sparc/kernel: Eliminate what looks like a NULL pointer dereference

At the point of the test, action cannot be NULL, as it has been dereferenced
in the code just above.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
}
else S3
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0fc251d9
...@@ -183,7 +183,7 @@ void sun4d_free_irq(unsigned int irq, void *dev_id) ...@@ -183,7 +183,7 @@ void sun4d_free_irq(unsigned int irq, void *dev_id)
goto out_unlock; goto out_unlock;
} }
if (action && tmp) if (tmp)
tmp->next = action->next; tmp->next = action->next;
else else
*actionp = action->next; *actionp = action->next;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment