Commit 0d462d9e authored by Axel Lin's avatar Axel Lin Committed by Ben Hutchings

PM / devfreq: Add proper locking around list_del()

commit 0f376c9c upstream.

Use devfreq_list_lock around list_del() to prevent list corruption.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent d7070443
...@@ -507,17 +507,19 @@ struct devfreq *devfreq_add_device(struct device *dev, ...@@ -507,17 +507,19 @@ struct devfreq *devfreq_add_device(struct device *dev,
if (devfreq->governor) if (devfreq->governor)
err = devfreq->governor->event_handler(devfreq, err = devfreq->governor->event_handler(devfreq,
DEVFREQ_GOV_START, NULL); DEVFREQ_GOV_START, NULL);
mutex_unlock(&devfreq_list_lock);
if (err) { if (err) {
dev_err(dev, "%s: Unable to start governor for the device\n", dev_err(dev, "%s: Unable to start governor for the device\n",
__func__); __func__);
goto err_init; goto err_init;
} }
mutex_unlock(&devfreq_list_lock);
return devfreq; return devfreq;
err_init: err_init:
list_del(&devfreq->node); list_del(&devfreq->node);
mutex_unlock(&devfreq_list_lock);
device_unregister(&devfreq->dev); device_unregister(&devfreq->dev);
err_dev: err_dev:
kfree(devfreq); kfree(devfreq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment