Commit 151b8c5b authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Linus Walleij

pinctrl: sirf: atlas7: Add missing of_node_put

of_find_node_by_name does an of_node_get on its return value,
so an of_node_put is needed on this value before the corresponding
variable goes out of scope.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct device_node *n;
struct device_node *n1;
statement S;
identifier f;
expression E;
constant C;
@@

n = of_find_node_by_name(...)
...
if (!n) S
... when != of_node_put(n)
    when != n1 = f(n,...)
    when != E = n
    when any
    when strict
(
+ of_node_put(n);
  return -C;
|
  of_node_put(n);
|
  n1 = f(n,...)
|
  E = n
|
  return ...;
)
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cc4fa83f
...@@ -5424,8 +5424,10 @@ static int atlas7_pinmux_probe(struct platform_device *pdev) ...@@ -5424,8 +5424,10 @@ static int atlas7_pinmux_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
pmx->sys2pci_base = devm_ioremap_resource(&pdev->dev, &res); pmx->sys2pci_base = devm_ioremap_resource(&pdev->dev, &res);
if (IS_ERR(pmx->sys2pci_base)) if (IS_ERR(pmx->sys2pci_base)) {
of_node_put(sys2pci_np);
return -ENOMEM; return -ENOMEM;
}
pmx->dev = &pdev->dev; pmx->dev = &pdev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment