Commit 16cf6b80 authored by Maithili Hinge's avatar Maithili Hinge Committed by John W. Linville

mwifiex: change memset to simple assignment for ht_cap.mcs.rx_mask

WARNING: single byte memset is suspicious.
         Swapped 2nd/3rd argument?

This code happens to work because rx_mcs is the first variable
in mcs structure. We should use 'mcs.rx_mcs' here anyway.
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarMaithili Hinge <maithili@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6c9ec5eb
...@@ -175,17 +175,19 @@ mwifiex_set_ht_params(struct mwifiex_private *priv, ...@@ -175,17 +175,19 @@ mwifiex_set_ht_params(struct mwifiex_private *priv,
switch (GET_RXSTBC(cap_info)) { switch (GET_RXSTBC(cap_info)) {
case MWIFIEX_RX_STBC1: case MWIFIEX_RX_STBC1:
/* HT_CAP 1X1 mode */ /* HT_CAP 1X1 mode */
memset(&bss_cfg->ht_cap.mcs, 0xff, 1); bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;
break; break;
case MWIFIEX_RX_STBC12: /* fall through */ case MWIFIEX_RX_STBC12: /* fall through */
case MWIFIEX_RX_STBC123: case MWIFIEX_RX_STBC123:
/* HT_CAP 2X2 mode */ /* HT_CAP 2X2 mode */
memset(&bss_cfg->ht_cap.mcs, 0xff, 2); bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;
bss_cfg->ht_cap.mcs.rx_mask[1] = 0xff;
break; break;
default: default:
dev_warn(priv->adapter->dev, dev_warn(priv->adapter->dev,
"Unsupported RX-STBC, default to 2x2\n"); "Unsupported RX-STBC, default to 2x2\n");
memset(&bss_cfg->ht_cap.mcs, 0xff, 2); bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;
bss_cfg->ht_cap.mcs.rx_mask[1] = 0xff;
break; break;
} }
priv->ap_11n_enabled = 1; priv->ap_11n_enabled = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment