Commit 1a20c3f8 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Linus Walleij

gpio: altera-a10sr: constify gpio_chip structure

This structure is only used to copy into another structure, so declare
it as const.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct gpio_chip i@p = { ... };

@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct gpio_chip e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct gpio_chip i = { ... };

In the following log you can see a significant difference in the code size
and data segment, hence in the dec segment. This log is the output
of the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
   1954     600       0    2554     9fa drivers/gpio/gpio-altera-a10sr.o

after:
   text    data     bss     dec     hex filename
   1655     512       0    2167     877 drivers/gpio/gpio-altera-a10sr.o
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: default avatarThor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 8340e915
...@@ -71,7 +71,7 @@ static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc, ...@@ -71,7 +71,7 @@ static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
return -EINVAL; return -EINVAL;
} }
static struct gpio_chip altr_a10sr_gc = { static const struct gpio_chip altr_a10sr_gc = {
.label = "altr_a10sr_gpio", .label = "altr_a10sr_gpio",
.owner = THIS_MODULE, .owner = THIS_MODULE,
.get = altr_a10sr_gpio_get, .get = altr_a10sr_gpio_get,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment