Commit 1bad0fae authored by Brad Hards's avatar Brad Hards Committed by Trond Myklebust

[PATCH] possible keyspan debug bug

While doing some cleanups of duplication #include entries,
I found what looks like a minor bug.

The keyspan driver does #include <linux/usb.h> twice. Not
normally a problem, because of the idempotent constructions.

But in this case the behaviour of the dbg() module depends on
the value of DEBUG. Keyspan tries to handle this, but the
first #include is before the definition, and the second one
has no effect. Patch attached.

I don't have the hardware to test, but it sure looks wrong now.
parent 7b2706c3
...@@ -86,7 +86,6 @@ ...@@ -86,7 +86,6 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/spinlock.h> #include <linux/spinlock.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <linux/usb.h>
#ifdef CONFIG_USB_SERIAL_DEBUG #ifdef CONFIG_USB_SERIAL_DEBUG
static int debug = 1; static int debug = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment